-
Notifications
You must be signed in to change notification settings - Fork 147
Testing section #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing section #246
Conversation
.htaccess
Outdated
| redirect 301 /doc/sbt/depending.html {{ BASE_PATH }}/doc/project/dependencies.html | ||
| redirect 301 /doc/sbt/js-envs.html {{ BASE_PATH }}/doc/project/js-environments.html | ||
| redirect 301 /doc/sbt/cross-building.html {{ BASE_PATH }}/doc/project/cross-build.html | ||
| redirect 301 /doc/sbt/testing.html {{ BASE_PATH }}/doc/project/testing.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is needed. IIUC, these are just so that links to the old site still work (a comment would have been useful indeed).
|
@gzm0 done - link to test section removed + comment about the file added |
Now I hope what I said is actually the case :P |
|
@gzm0 I hope that someone will be able to approve/disapprove that, if not, then you're right anyways :) |
Yes, that's correct. We also add redirects when moving pages around, of course. So the comment, as written, is wrong. But there should not be a new entry in redirects for a new page like this. |
.htaccess
Outdated
| Change it ONLY if you deal with old site! | ||
| {% endcomment %} | ||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The appropriate comment would be simply:
Redirects for pages that were moved around.
(whether from the old site or the new site is completely irrelevant)
|
I'll review the actual content later. I'm on a clock, right now. |
.htaccess
Outdated
| Don't update this file if you are adding a new entry. | ||
| {% endcomment %} | ||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double blank line. (should be only 1)
|
That's all. |
|
@sjrd I believe I addressed all your comments in latest push. Thanks |
|
OK could you squash all the commits into 1, please? |
…ration testing aka it:test
|
Squashed to 1 commit per @sjrd request. |
|
LGTM |
Adding testing page to documentation explaining unit testing in cross project as well as how to configure integration testing in cross project. Let me know what you think. /cc @ochrons