Skip to content

Conversation

@AlexITC
Copy link
Contributor

@AlexITC AlexITC commented Jul 7, 2021

Add the wiringbits scala-webapp-template, and reorganize the existing links, some are outdated and others are archived, let's reflect that in the docs.

Comment on lines 61 to 65





Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blank lines ;)


### [Udash Generator](http://guide.udash.io/#/bootstrapping/generators)

Project generator for the Udash framework - creates a customized, complete and runnable Udash based application.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem like Udash is archived, is it? It even uses sbt-scalajs 1.6.0, so it must have been updated recently.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Udash-generator (which is the linked project) is archived: https://github.com/UdashFramework/udash-generator/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, it is up to you what I do with this one

Comment on lines +17 to +19
### [npm scalajs-starter](https://github.com/konradst/scalajs-starter)

Scala.js Node.js skeleton app / library handled with ```npm start```, ```build```, ```test```, ```clean``` commands.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one seems outdated. It uses sbt-scalajs 1.0.0-M8.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, I was keeping everything related to 1.0.0 as recent, I'll update the section

Copy link
Member

@sjrd sjrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Could you squash the two commits together, please?

Add the wiringbits scala-webapp-template, and reorganize the existing links, some are outdated and others are archived, let's reflect that in the docs.
@AlexITC
Copy link
Contributor Author

AlexITC commented Jul 7, 2021

Done, FYI: Github has the Squash and Merge option to do this

@sjrd sjrd merged commit 44f8b1d into scala-js:master Jul 7, 2021
@sjrd
Copy link
Member

sjrd commented Jul 7, 2021

Done, FYI: Github has the Squash and Merge option to do this

Yes, I know, but that doesn't create a Merge commit at all. I want a "Squash and create a Merge commit" option.

@AlexITC AlexITC deleted the patch-1 branch July 7, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants