Skip to content

Conversation

@sjrd
Copy link
Member

@sjrd sjrd commented Feb 11, 2022

To be merged later, once it is published.

@sjrd sjrd requested a review from gzm0 February 11, 2022 10:52
This is a **minor** release:

* It is backward binary compatible with all earlier versions in the 1.x series: libraries compiled with 1.0.x through 1.8.x can be used with 1.9.0 without change.
* It is *not* forward binary compatible with 1.8.x: libraries compiled with 1.9.0 cannot be used with 1.8.x or earlier.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is lie; it is actually forward binary compatible, for once. But IMO it's easier to communicate it this way not to create some confusion.

@sjrd
Copy link
Member Author

sjrd commented Feb 13, 2022

Ping @gzm0 ?

@gzm0
Copy link
Contributor

gzm0 commented Feb 13, 2022

I have not forgotten about this :) Just had a bunch of thoughts that were not easy to follow-up on mobile :)

This is a **minor** release:

* It is backward binary compatible with all earlier versions in the 1.x series: libraries compiled with 1.0.x through 1.8.x can be used with 1.9.0 without change.
* It is *not* forward binary compatible with 1.8.x: libraries compiled with 1.9.0 cannot be used with 1.8.x or earlier.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than bending the truth here, how about explicitly pointing out that this is an uncommon release in terms of binary compat? For example:

  • Despite this being a minor release, 1.9.0 is forward binary compatible with 1.8.x: libraries ...

I'm concerned that we might cause more confusion otherwise because information is inconsistent (notably for the binary compat badges).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good point. I have amended the formulation here.


As a reminder, libraries compiled with 0.6.x cannot be used with Scala.js 1.x; they must be republished with 1.x first.

## Strict floats by default
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should mention somewhere that strict floats is a linking time decision (and therefore applies to the whole program).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added that at the end of the section "What changes". WDYT?

@sjrd sjrd requested a review from gzm0 February 13, 2022 17:16
Copy link
Contributor

@gzm0 gzm0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit: The usage of v prefix for versions feels inconsistent (see example comment).

Not sure it is super important. Feel free to merge unchanged.

This is a **minor** release:

* It is backward binary compatible with all earlier versions in the 1.x series: libraries compiled with 1.0.x through 1.8.x can be used with 1.9.0 without change.
* Despite being a minor release, v1.9.0 is forward binary compatible with 1.8.x. It is *not* forward binary compatible with 1.7.x. Libraries compiled with 1.9.0 can be used with 1.8.x but not with 1.7.x or earlier.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: 1.9.0 instead of v1.9.0?

@sjrd sjrd merged commit f739002 into scala-js:main Feb 14, 2022
@sjrd sjrd deleted the scalajs-1.9.0 branch February 14, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants