-
Notifications
You must be signed in to change notification settings - Fork 148
Announcing Scala.js 1.9.0. #566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| This is a **minor** release: | ||
|
|
||
| * It is backward binary compatible with all earlier versions in the 1.x series: libraries compiled with 1.0.x through 1.8.x can be used with 1.9.0 without change. | ||
| * It is *not* forward binary compatible with 1.8.x: libraries compiled with 1.9.0 cannot be used with 1.8.x or earlier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is lie; it is actually forward binary compatible, for once. But IMO it's easier to communicate it this way not to create some confusion.
|
Ping @gzm0 ? |
|
I have not forgotten about this :) Just had a bunch of thoughts that were not easy to follow-up on mobile :) |
| This is a **minor** release: | ||
|
|
||
| * It is backward binary compatible with all earlier versions in the 1.x series: libraries compiled with 1.0.x through 1.8.x can be used with 1.9.0 without change. | ||
| * It is *not* forward binary compatible with 1.8.x: libraries compiled with 1.9.0 cannot be used with 1.8.x or earlier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than bending the truth here, how about explicitly pointing out that this is an uncommon release in terms of binary compat? For example:
- Despite this being a minor release, 1.9.0 is forward binary compatible with 1.8.x: libraries ...
I'm concerned that we might cause more confusion otherwise because information is inconsistent (notably for the binary compat badges).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good point. I have amended the formulation here.
|
|
||
| As a reminder, libraries compiled with 0.6.x cannot be used with Scala.js 1.x; they must be republished with 1.x first. | ||
|
|
||
| ## Strict floats by default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should mention somewhere that strict floats is a linking time decision (and therefore applies to the whole program).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added that at the end of the section "What changes". WDYT?
gzm0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit: The usage of v prefix for versions feels inconsistent (see example comment).
Not sure it is super important. Feel free to merge unchanged.
| This is a **minor** release: | ||
|
|
||
| * It is backward binary compatible with all earlier versions in the 1.x series: libraries compiled with 1.0.x through 1.8.x can be used with 1.9.0 without change. | ||
| * Despite being a minor release, v1.9.0 is forward binary compatible with 1.8.x. It is *not* forward binary compatible with 1.7.x. Libraries compiled with 1.9.0 can be used with 1.8.x but not with 1.7.x or earlier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: 1.9.0 instead of v1.9.0?
To be merged later, once it is published.