Skip to content

Server socket implementation #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 138 commits into from
Sep 7, 2017
Merged

Server socket implementation #917

merged 138 commits into from
Sep 7, 2017

Conversation

@asoltysik
Copy link
Contributor

@asoltysik asoltysik commented Jul 31, 2017 •
edited
Loading

Two things missing:

  • Proper testing
  • Allow custom SocketImpl implementations for the method accept.

asoltysik and others added 30 commits June 10, 2017 16:53
@asoltysik
InetAddress
9ad0226
@asoltysik
Port Inet6AddressSuite, mention Apache Harmony and fix some bugs
2b09f8c
@asoltysik
Travis has no idea what localhost means
f5786b0
@asoltysik
isReachable
6114d6a
@asoltysik
typo
9541276
@asoltysik
mention Harmony, fix javatoscala leftovers, add commented signature
8189ad3
@asoltysik
Merge branch 'master' of https://github.com/scala-native/scala-native …
48cec75 
…into inet
@asoltysik
Merge branch 'master' of https://github.com/scala-native/scala-native …
136abd8 
…into inet
@asoltysik
Merge branch 'master' of https://github.com/scala-native/scala-native …
bceed54 
…into inet
@asoltysik
netdb bindings
db445f4
@asoltysik
bindings and unfinished port of SocketHelpers from C to Scala
6e04e0c
@asoltysik
fix for tcp echo
a934355
@asoltysik
removed ICMP echo
9fbc64c
@asoltysik
missing free in socket.connect
b48fc07
@asoltysik
clangfmt
365403f
@asoltysik
Merge branch 'master' into inet
bd1fae7
@asoltysik
sbt rebuild no longer blows up
7e4d239
@asoltysik
refactor InetAddress.getHostAddress
2bc0864
@asoltysik
double definition of connect
a9dd2b2
@asoltysik
include guards and some missing frees
665b330
@asoltysik
change suseconds_t to int
4a361d5
@asoltysik
ioctl bindings
9fee147
@asoltysik
change FileDescriptor's package-private constructor to java package
d710ac1
@asoltysik
socket input/output streams
a7dbe74
@asoltysik
A proof of concept tcp socket implementation
9c0e827
@asoltysik
Merge branch 'master' of https://github.com/scala-native/scala-native …
1176abb 
…into inet
@asoltysik
companion object inheritance fix, formatting and unused type signature
83beb45
@asoltysik
dont set errno manually
2491f9a
@asoltysik
initial implemenatation of tcp sockets
d5a2054
@asoltysik
a bug in getByName and access modifiers
03eafb0
asoltysik added 18 commits July 17, 2017 17:33
@densh
Copy link
Member

densh commented Aug 7, 2017

Needs squash and rebase due to conflicting changes on master.

@asoltysik asoltysik changed the title [WIP] Server socket implementation Server socket implementation Aug 10, 2017
@densh
Copy link
Member

densh commented Aug 18, 2017

Please rebase your PR on top of latest master due to CI changes, thanks!

@asoltysik asoltysik mentioned this pull request Aug 22, 2017
Closed
6 tasks
@densh
Copy link
Member

densh commented Aug 31, 2017

Ping @asoltysik, this PR is blocked by the recent conflicting changes on master.

@asoltysik
Copy link
Contributor Author

@densh done.

densh
densh approved these changes Sep 7, 2017
View reviewed changes
Copy link
Member

@densh densh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @asoltysik ! 🍰

@densh densh merged commit f929ea5 into scala-native:master Sep 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@densh densh densh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@asoltysik @densh @ekrich @matil019 @Duhemm @mccartney @xuwei-k @muxanick @allanrenucci