Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflection: FieldMirror is a leaky abstraction #5895

Closed
scabug opened this issue Jun 7, 2012 · 3 comments
Closed

Reflection: FieldMirror is a leaky abstraction #5895

scabug opened this issue Jun 7, 2012 · 3 comments
Assignees
Milestone

Comments

@scabug
Copy link

@scabug scabug commented Jun 7, 2012

The problem is demonstrated in #5889, in which reflectField is passed a method symbol and bad things happen.

Well, you can say, implement a sanity check and don't pass non-field symbols to reflectField. But that gets ugly very quickly, because to get a handle on a field symbol one needs to append nme.LOCAL_SUFFIX_STRING to the field's name. To put it in a nutshell, the "field symbol" is not a good one.

Another idea of fixing the problem would be to do away with FieldMirrors and require all field accesses to go through accessor methods. Unfortunately, this won't work either, since not all fields generate accessors (e.g. private[this] ones).

@scabug

This comment has been minimized.

Copy link
Author

@scabug scabug commented Jun 7, 2012

Imported From: https://issues.scala-lang.org/browse/SI-5895?orig=1
Reporter: @xeno-by
Affected Versions: 2.10.0

@scabug

This comment has been minimized.

Copy link
Author

@scabug scabug commented Jul 11, 2012

@scabug

This comment has been minimized.

Copy link
Author

@scabug scabug commented Jul 20, 2012

@scabug scabug closed this Jul 20, 2012
@scabug scabug added this to the 2.10.0-M5 milestone Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.