New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrote singleton objects tour #704

Closed
wants to merge 1 commit into
base: master
from

Conversation

5 participants
@travissarles
Collaborator

travissarles commented Feb 19, 2017

No description provided.

@travissarles

This comment has been minimized.

Show comment
Hide comment
@travissarles

travissarles Mar 14, 2017

Collaborator

@heathermiller ready to merge

Collaborator

travissarles commented Mar 14, 2017

@heathermiller ready to merge

@SethTisue

This comment has been minimized.

Show comment
Hide comment
@SethTisue

SethTisue Mar 14, 2017

Member

Both the old and new texts assume that object appears at the top level, in which case it is truly a singleton classloader-wide. But you can also nest object within other constructs and then there's more than one — it's only a singleton in that context.

Since the old text also had this problem, I think this PR could be merged anyway, but Travis, perhaps you're motivated to add some wording that addresses this? If not, perhaps we (or someone) can come back to it later.

Otherwise LGTM for merge.

Member

SethTisue commented Mar 14, 2017

Both the old and new texts assume that object appears at the top level, in which case it is truly a singleton classloader-wide. But you can also nest object within other constructs and then there's more than one — it's only a singleton in that context.

Since the old text also had this problem, I think this PR could be merged anyway, but Travis, perhaps you're motivated to add some wording that addresses this? If not, perhaps we (or someone) can come back to it later.

Otherwise LGTM for merge.

@travissarles travissarles referenced this pull request Mar 17, 2017

Closed

Rewrite tour of Scala #733

33 of 33 tasks complete

@travissarles travissarles moved this from In PR to Ready to Merge in Rewrite Tour of Scala May 9, 2017

@som-snytt

This comment has been minimized.

Show comment
Hide comment
@som-snytt

som-snytt Jan 10, 2018

Contributor

Rebased at #978

Contributor

som-snytt commented Jan 10, 2018

Rebased at #978

@som-snytt som-snytt closed this Jan 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment