FIX #141 Upgrading to native-packager 1.0.4 and autoplugins #142
Conversation
|
Thanks again, @muuki88, and happy holidays! We'll use this to roll 2.11.6 and 2.12.0-M1. I unfortunately ran out of time for 2.11.5 -- our Jenkins caught fire, so I've been swamped with that. |
adriaanm
force-pushed
the
2.11.x
branch
3 times, most recently
from
b8f2d81
to
2035c46
Compare
|
Testing on our new release CI: http://scala-ci.typesafe.com/job/scala-release-2.11.x/8/console |
|
Ahh... windows needs some love as well http://scala-ci.typesafe.com/job/scala-release-2.11.x-windows/5/console |
|
@adriaanm does this need some attention? |
|
It would be good to upgrade if/when possible. |
|
I can upgrade the versions ( unfortunately in two weeks ) if this helps. |
|
@muuki88 ping! still interested? |
|
@muuki88 does this result in any user-visible changes that we should mention in the release notes? |
|
Nothing I can think of. Startscript, permissions stay the same. |
SethTisue
changed the title
FIX #141 Upgrading to native-packager 1.0.4 and autoplugins
|
Thanks Muuki! |
|
oh, I shouldn't have merged this, it breaks on Windows: https://scala-ci.typesafe.com/job/scala-2.11.x-release-package-windows/295/console . I should have inquired more closely about Muuki's earlier comment about it. |
|
I'll try to have a look this or next week. Have to setup a windows machine :D |
|
In the mean time, could we revert to get the nightlies back to green? |
|
Thanks for looking into this, @muuki88! |
|
reverted in 07c4270 |
the upgrade turned out to be way too problematic. even after multiple PRs addressing regressions, new ones continue to turn up; see scala/scala-dev#92 for details on the latest regressions. for past history (including details on regressions), see these PRs in this repo: scala#159, scala#157, scala#156, scala#155, scala#154, scala#142, plus issue so what's next after this? - we could maybe still consider upgrading for 2.11.9, but someone would need to thoroughly QA it on all platforms and assure us there are no regressions - or we could restrict the upgrade to 2.12.x and hope for partially crowdsourced QA so that regressions would be caught during the milestone and release candidate phases. I lean towards leaving 2.11.x frozen at 0.6.4, at least unless the upgrade brings concrete benefits to end users (no one has listed any, to my knowledge). if this is mainly just dogfooding, then 2.12.x is a better context for that.
this restores the 2.11.7 status quo for the 2.11.8 release. the upgrade turned out to be way too problematic. even after multiple PRs addressing regressions, new ones continue to turn up; see scala/scala-dev#92 for details on the latest regressions. for past history (including details on regressions), see these PRs in this repo: scala#159, scala#157, scala#156, scala#155, scala#154, scala#142, plus issue so what's next after this? - we could maybe still consider upgrading for 2.11.9, but someone would need to thoroughly QA it on all platforms and assure us there are no regressions - or we could restrict the upgrade to 2.12.x and hope for partially crowdsourced QA so that regressions would be caught during the milestone and release candidate phases. I lean towards leaving 2.11.x frozen at 0.6.4, at least unless the upgrade brings concrete benefits to end users (no one has listed any, to my knowledge). if this is mainly just dogfooding, then 2.12.x is a better context for that.
Merry Christmas 🎄
Seems like the
0644chmod before the copy destroys the copy attempt of sbt.However using the jdeb implementation works just fine (seem so).