Build fixes; license; groupId = org.scala-lang.modules

The license is a standard 3-clause BSD license.

We're publishing modules under org.scala-lang.modules.
This signals they are "just another Scala library":
  - cross-versioned (cross-versioning under org.scala-lang confuses sbt)
  - backward binary compatible (but not forward like the core)

Compile under Optimize/Deprecation/Features/Lint.

Author: adriaanm

LICENSE.md

@@ -0,0 +1,28 @@
+Copyright (c) 2002-2013 EPFL
+Copyright (c) 2011-2013 Typesafe, Inc.
+
+All rights reserved.
+
+Redistribution and use in source and binary forms, with or without modification,
+are permitted provided that the following conditions are met:
+
+    * Redistributions of source code must retain the above copyright notice,
+      this list of conditions and the following disclaimer.
+    * Redistributions in binary form must reproduce the above copyright notice,
+      this list of conditions and the following disclaimer in the documentation
+      and/or other materials provided with the distribution.
+    * Neither the name of the EPFL nor the names of its contributors
+      may be used to endorse or promote products derived from this software
+      without specific prior written permission.
+
+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR
+CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
+LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
+NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

build.sbt

@@ -1,30 +1,43 @@
-organization := "org.scala-lang"
+organization := "org.scala-lang.modules"
 
 name := "scala-partest"
 
-version := "1.0-RC1"
+version := "1.0-RC2"
 
-scalaVersion := "2.11.0-M4"
-
-scalaBinaryVersion := scalaVersion.value
 
+// dependencies:
 libraryDependencies += "org.apache.ant"                 % "ant"            % "1.8.4"
 
 libraryDependencies += "com.googlecode.java-diff-utils" % "diffutils"      % "1.3.0"
 
-libraryDependencies += "org.scala-lang"                 % "scala-xml"      % "2.11.0-M4"
+libraryDependencies += "org.scala-sbt"                  % "test-interface" % "1.0"
+
+libraryDependencies += "org.scalacheck"                %% "scalacheck"     % "1.10.1"
+
+libraryDependencies += "org.scala-lang.modules"        %% "scala-xml"      % "1.0-RC2"
 
 libraryDependencies += "org.scala-lang"                 % "scalap"         % "2.11.0-M4"
 
-libraryDependencies += "org.scalacheck"                %% "scalacheck"     % "1.10.1"
 
-libraryDependencies += "org.scala-sbt"                  % "test-interface" % "1.0"
+// standard stuff follows:
+scalaVersion := "2.11.0-M4"
 
+// NOTE: not necessarily equal to scalaVersion
+// (e.g., during PR validation, we override scalaVersion to validate,
+// but don't rebuild scalacheck, so we don't want to rewire that dependency)
+scalaBinaryVersion := "2.11.0-M4"
 
-// partest.properties
+// don't use for doc scope, scaladoc warnings are not to be reckoned with
+scalacOptions in compile ++= Seq("-optimize", "-Xfatal-warnings", "-feature", "-deprecation", "-unchecked", "-Xlint")
+
+
+// Generate $name.properties to store our version as well as the scala version used to build
+// TODO: why doesn't this work for scala-partest.properties?? (After updating def propCategory in Properties, of course)
 resourceGenerators in Compile <+= Def.task {
   val props = new java.util.Properties
   props.put("version.number", version.value)
+  props.put("scala.version.number", scalaVersion.value)
+  props.put("scala.binary.version.number", scalaBinaryVersion.value)
   val file = (resourceManaged in Compile).value / "partest.properties"
   IO.write(props, null, file)
   Seq(file)
@@ -55,24 +68,23 @@ pomExtra := (
   <inceptionYear>2002</inceptionYear>
   <licenses>
     <license>
-      <name>BSD-like</name>
-      <url>http://www.scala-lang.org/downloads/license.html
-      </url>
-      <distribution>repo</distribution>
+        <distribution>repo</distribution>
+        <name>BSD 3-Clause</name>
+        <url>https://github.com/scala/{name.value}/blob/master/LICENSE.md</url>
     </license>
-  </licenses>
+   </licenses>
   <scm>
-    <connection>scm:git:git://github.com/scala/scala-partest.git</connection>
-    <url>https://github.com/scala/scala-partest</url>
+    <connection>scm:git:git://github.com/scala/{name.value}.git</connection>
+    <url>https://github.com/scala/{name.value}</url>
   </scm>
   <issueManagement>
     <system>JIRA</system>
     <url>https://issues.scala-lang.org/</url>
   </issueManagement>
   <developers>
     <developer>
-      <id>lamp</id>
-      <name>EPFL LAMP</name>
+      <id>epfl</id>
+      <name>EPFL</name>
     </developer>
     <developer>
       <id>Typesafe</id>
@@ -81,8 +93,3 @@ pomExtra := (
   </developers>
 )
 
-// TODO: mima
-// import com.typesafe.tools.mima.plugin.MimaPlugin.mimaDefaultSettings
-// import com.typesafe.tools.mima.plugin.MimaKeys.previousArtifact
-// previousArtifact := Some("org.scala-lang" % "partest_2.11.0-M4" % "1.0")
-

src/main/scala/scala/tools/partest/utils/Properties.scala

@@ -10,7 +10,7 @@
 package scala.tools.partest
 package utils
 
-/** Loads partest.properties from the jar. */
+/** Loads partest.properties from the jar. TODO: standardize on scala-partest.properties */
 object Properties extends scala.util.PropertiesTrait {
   protected def propCategory    = "partest"
   protected def pickJarBasedOn  = classOf[nest.Runner]