Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.0.0 (RC, then final) #432

Closed
ashawley opened this issue May 27, 2020 · 19 comments
Closed

Release 2.0.0 (RC, then final) #432

ashawley opened this issue May 27, 2020 · 19 comments

Comments

@ashawley
Copy link
Member

ashawley commented May 27, 2020

1. Release the #392 fix that has been available in 1.3.0. done in M2
1. Drop Scala.js 0.6.x? See #430 done in M2

  1. Fix RuleTransformer defect Subsequent RewriteRules don't transform elements added in previous transform. #257 with Make RuleTransformer fully recursive [#257] #421? (Needs review.)
  2. Update CHANGELOG (In particular, the differences are from 1.3.0, not 1.2.0)
@SethTisue
Copy link
Member

no objection here to dropping sjs 0.6

@SethTisue SethTisue self-assigned this Sep 15, 2020
@SethTisue SethTisue changed the title Release 2.0.0-M2 Release 2.0.0-M3 Sep 15, 2020
@SethTisue
Copy link
Member

SethTisue commented Sep 15, 2020

I'm building M2 right now in order to get a Dotty version out, so I've retitled this ticket to be about M3.

@SethTisue SethTisue removed their assignment Sep 15, 2020
@SethTisue
Copy link
Member

probably makes sense to add 3.0.0-M1 support first: #466

@SethTisue SethTisue changed the title Release 2.0.0-M3 Release 2.0.0-M4 Nov 26, 2020
@SethTisue
Copy link
Member

I'm going to roll M3 today in order to get a release out for Scala 3.0.0-M2: #471

@SethTisue
Copy link
Member

I'm going to roll M4 today to release for Scala Native 0.4: #484

@SethTisue SethTisue changed the title Release 2.0.0-M4 Release 2.0.0-Mx or -RCx Jan 30, 2021
@SethTisue
Copy link
Member

SethTisue commented Feb 18, 2021

I rolled M5 today with Scala 3.0.0-RC1 support.

@ashawley are you interested in going 2.0.0-RC1?

@ashawley
Copy link
Member Author

To be honest, the hope was to fix some of the long-standing bugs in a 2.0, but I haven't had time to go back and do that work. In that vein, I was considering going with 2.0.0-Mx as long as possible unless something really compelled a 2.0 final. I haven't had time to contribute or even track the latest developments here, so feel free to cut 2.0 versions if it's useful.

@SethTisue
Copy link
Member

cool, thanks for the update!

personally I'm content to leave it in milestone limbo for the time being, but once Scala 3.0.0 arrives, I think that might a good time to just say to ourselves "it is what it is" and go RC1 and then final with whatever we have. (and if there turn out to be problems, either volunteers materialize who care enough to fix them, or they don't.)

@SethTisue
Copy link
Member

SethTisue commented Mar 3, 2021

thinking about this again, wondering if we are moving too slow

an example of the kind of trouble this causes downstream is scalatest/scalatest#1973

maybe we should actually go RC1 earlier? as in, like.... now? in order to be in position to do a 2.0 final version at around the same time 3.0.0 comes out?

@ashawley I suggest we go RC1 unless you can either 1) concretely commit to make specific changes you want to make within a concrete timeframe, or 2) at least identify what you consider blockers or candidate blockers so we can see if there are volunteers who want to tackle them pronto

bugs can always be fixed post-2.0 unless they affect binary compatibility; do you have anything in mind that would make MiMa squawk, later, if it was postponed?

@SethTisue
Copy link
Member

SethTisue commented Mar 3, 2021

@SethTisue SethTisue changed the title Release 2.0.0-Mx or -RCx Release 2.0.0 (RC, then final) Mar 3, 2021
@ashawley
Copy link
Member Author

ashawley commented Mar 3, 2021

Yes, I assumed that it would be useful to have a 2.0.0 final for the Scala 3.0 process. Feel free to do that.

The major fixes I envisioned can just be pushed to a version 3.0 of scala-xml.

@SethTisue
Copy link
Member

SethTisue commented Mar 3, 2021

Note that we should land #176 (reusing SAXParser instance) and #177 (safer default parsing settings) first unless some serious objection is raised. Dear community: last call for reviews/objections on those!

@ashawley
Copy link
Member Author

ashawley commented Mar 3, 2021

The only issue with a 2.0.0 final is fixing #413 which was an attempt to fix an old XML quoting bug, #57. Might be easiest and best to just roll that back and reopen the bug.

@rossabaker
Copy link

http4s has upgraded to scala-xml-2 because it was the only way to get Scala 3 support without withDottyCompat. We'll probably be spinning this support off to a satellite repo, so we're not tied to scala-xml's release cycle. But from our perspective, a 2.0.0 would be very welcome.

@SethTisue
Copy link
Member

SethTisue commented Mar 4, 2021

I've merged #176 and #177 and submitted #496 which fixes #413 (and reopens #57) by reverting #279

@SethTisue
Copy link
Member

afaik, once #501 is merged we'll be good to go to do 2.0.0-RC1. I suggest we do that right after Scala 3.0.0-RC2 comes out (since we'll need to be publishing something then anyway).

@SethTisue SethTisue assigned SethTisue and unassigned SethTisue Mar 16, 2021
@SethTisue
Copy link
Member

SethTisue commented Mar 29, 2021

Scala 3.0.0-RC2 is out. I will roll scala-xml 2.0.0-RC1 now: #502

@SethTisue SethTisue mentioned this issue Mar 29, 2021
8 tasks
@SethTisue
Copy link
Member

backpublished 2.0.0-RC1 for Scala 3.0.0-RC3

@SethTisue SethTisue mentioned this issue May 13, 2021
8 tasks
@SethTisue
Copy link
Member

Looks like we're done here except for publishing: #521

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants