Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify SBT to have api mapping to Scala library for scaladoc #119

Merged
merged 1 commit into from Apr 26, 2017

Conversation

ashawley
Copy link
Member

@SethTisue
Copy link
Member

LGTM. I see in the Travis log there are fewer warnings during Scaladoc generation now.

a few still remain for other libraries:

[warn] /home/travis/build/scala/scala-xml/src/main/scala/scala/xml/parsing/FactoryAdapter.scala:165: Could not find any member to link for "org.xml.sax.SAXException".
[warn]   /**
[warn]   ^
[warn] /home/travis/build/scala/scala-xml/src/main/scala/scala/xml/include/XIncludeException.scala:13: Could not find any member to link for "java.lang.Throwable#getMessage".
[warn] /**
[warn] ^
[warn] /home/travis/build/scala/scala-xml/src/main/scala/scala/xml/include/sax/EncodingHeuristics.scala:39: Could not find any member to link for "IOException".
[warn]   /**
[warn]   ^
[warn] three warnings found

@ashawley
Copy link
Member Author

Yes, a few warnings related to the Java standard library remain. There might be a way to handle those references, but I couldn't find one for SBT. We could take it up later in another PR.

@SethTisue
Copy link
Member

We could take it up later in another PR

indeed, no reason not to go ahead and merge this one

@SethTisue
Copy link
Member

needs rebase now. LGTM otherwise and I would suggest we merge in a few days, after the rebase, if there are no actual objections

@ashawley
Copy link
Member Author

ashawley commented Feb 4, 2017

Rebased, travis build succeeds, and there are still fewer scaladoc warnings.

* build.sbt (apiMappings): Add mapping to scala-lang.org URL.
@ashawley ashawley merged commit 383f5fa into scala:master Apr 26, 2017
@ashawley ashawley deleted the fix-118-scaladoc-links branch April 26, 2017 03:40
@ashawley ashawley mentioned this pull request Oct 9, 2017
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants