Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested XML adds empty xmlns attribute #45 #91

Closed
wants to merge 1 commit into from
Closed

Nested XML adds empty xmlns attribute #45 #91

wants to merge 1 commit into from

Conversation

ashawley
Copy link
Member 

* src/test/scala/scala/xml/XMLTest.scala (namespacesWithNestedXmls):
Modified test case by Muntis Grūbe.

* src/main/scala/scala/xml/NamespaceBinding.scala (doBuildString):
Add TopScope as a value to avoid building the namespace attribute
string.

@ashawley
Nested XML adds empty xmlns attribute scala#45
596f183 
	* src/test/scala/scala/xml/XMLTest.scala (namespacesWithNestedXmls):
	Modified test case by Muntis Grūbe.

	* src/main/scala/scala/xml/NamespaceBinding.scala (doBuildString):
	Add TopScope as a value to avoid building the namespace attribute
	string.
@ncanibano
Copy link

+1

@biswanaths
Copy link
Contributor

Done !!

Thank you Aaron.

@biswanaths biswanaths closed this Apr 14, 2016
@ashawley
Copy link
Member Author

@biswanaths You're welcome! You can close PR #47, since you used #91.

@ashawley ashawley deleted the fix-45-nested-xml-ns-defect branch April 14, 2016 13:46
@adriaanm adriaanm mentioned this pull request Apr 22, 2016
Closed
@ashawley ashawley mentioned this pull request Mar 27, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashawley @ncanibano @biswanaths