Ignore ascriptions from ensureNoLocalRefs in ReTyper

Author: mbovel

compiler/src/dotty/tools/dotc/typer/ReTyper.scala

@@ -58,6 +58,9 @@ class ReTyper(nestingLevel: Int = 0) extends Typer(nestingLevel) with ReChecking
   override def typedTyped(tree: untpd.Typed, pt: Type)(using Context): Tree = {
     assertTyped(tree)
 
+    if tree.hasAttachment(Typer.NoLocalRefsAscription) then
+      return typedExpr(tree.expr, pt)
+
     val tpt1 = checkSimpleKinded(typedType(tree.tpt))
     val expr1 = tree.expr match {
       case id: untpd.Ident if (ctx.mode is Mode.Pattern) && untpd.isVarPattern(id) && (id.name == nme.WILDCARD || id.name == nme.WILDCARD_STAR) =>

compiler/src/dotty/tools/dotc/typer/Typer.scala

@@ -86,6 +86,9 @@ object Typer {
   /** Indicates that an expression is explicitly ascribed to [[Unit]] type. */
   val AscribedToUnit = new Property.StickyKey[Unit]
 
+  /** Indicates that this ascription was inserted by `ensureNoLocalRefs`. */
+  val NoLocalRefsAscription = new Property.StickyKey[Unit]
+
   /** Tree adaptation lost fidelity; this attachment preserves the original tree. */
   val AdaptedTree = new Property.StickyKey[tpd.Tree]
 
@@ -1580,7 +1583,7 @@ class Typer(@constructorOnly nestingLevel: Int = 0) extends Namer
       case _ =>
         val target = pt.simplified
         val targetTpt = TypeTree(target, inferred = true)
-        if tree.tpe <:< target then Typed(tree, targetTpt)
+        if tree.tpe <:< target then Typed(tree, targetTpt).withAttachment(NoLocalRefsAscription, ())
         else
           // This case should not normally arise. It currently does arise in test cases
           // pos/t4080b.scala and pos/i7067.scala. In that case, a type ascription is wrong

tests/run/i24420-transparent-inline-local-ref.scala

@@ -0,0 +1,12 @@
+transparent inline def f(): Long =
+  1L
+
+transparent inline def g(): Long =
+  inline val x = f()
+  x
+
+transparent inline def h(): Long =
+  inline if g() > 0L then 1L else 0L
+
+@main def Test: Unit =
+  assert(h() == 1L)