Add error message IdentifierExpected

This commit adds the semantic object fir the ```identifier expected``` error.
It is part of the #1589

Author: iamthiago

src/dotty/tools/dotc/parsing/JavaParsers.scala

@@ -7,7 +7,6 @@ import dotty.tools.dotc.core.Flags
 import dotty.tools.dotc.core.Flags.FlagSet
 
 import scala.language.implicitConversions
-
 import JavaTokens._
 import JavaScanners._
 import Scanners.Offset
@@ -21,8 +20,10 @@ import Symbols._
 import ast.Trees._
 import Decorators._
 import StdNames._
+import dotty.tools.dotc.reporting.diagnostic.messages.IdentifierExpected
 import dotty.tools.dotc.util.SourceFile
 import util.Positions._
+
 import annotation.switch
 import scala.collection.mutable.ListBuffer
 import scala.reflect.internal.util.Collections._
@@ -230,7 +231,7 @@ object JavaParsers {
         case AppliedTypeTree(_, _) | Select(_, _) =>
           tree
         case _ =>
-          syntaxError("identifier expected", tree.pos)
+          syntaxError(IdentifierExpected(), tree.pos)
           errorTypeTree
       }
     }

src/dotty/tools/dotc/parsing/MyTest.scala

@@ -0,0 +1,34 @@
+package dotty.tools.dotc.parsing
+
+import dotty.tools.dotc.ast.untpd._
+import dotty.tools.dotc.core.Contexts.{ContextBase, FreshContext}
+import dotty.tools.dotc.parsing.Parsers.Parser
+import dotty.tools.dotc.util.SourceFile
+
+import scala.collection.mutable.ListBuffer
+import scala.io.Codec
+import scala.reflect.io.PlainFile
+
+object MyTest {
+
+  def main(args: Array[String]): Unit = {
+
+    implicit val ctx: FreshContext = new ContextBase().initialCtx.fresh
+
+    var parsed = 0
+    val parsedTrees = new ListBuffer[Tree]
+
+    def parse(name: String): Tree = {
+      //println("***** parsing " + file)
+      val file = new PlainFile(name)
+      val source = new SourceFile(file, Codec.UTF8)
+      val parser = new Parser(source)
+      val tree = parser.parse()
+      parsed += 1
+      parsedTrees += tree
+      tree
+    }
+
+    parse("/Users/thiagopereira/Downloads/Test.scala")
+  }
+}

src/dotty/tools/dotc/parsing/Parsers.scala

@@ -316,7 +316,7 @@ object Parsers {
       case id @ Select(qual, name) =>
         cpy.Select(id)(qual, name.toTypeName)
       case _ =>
-        syntaxError("identifier expected", tree.pos)
+        syntaxError(IdentifierExpected(), tree.pos)
         tree
     }
 

src/dotty/tools/dotc/reporting/diagnostic/messages.scala

@@ -6,11 +6,9 @@ package diagnostic
 import dotc.core._
 import Contexts.Context, Decorators._, Symbols._, Names._, NameOps._, Types._
 import ast.untpd.{Modifiers, ModuleDef}
-import util.{SourceFile, NoSource}
-import util.{SourcePosition, NoSourcePosition}
+import util.SourcePosition
 import config.Settings.Setting
 import interfaces.Diagnostic.{ERROR, WARNING, INFO}
-import dotty.tools.dotc.ast.tpd
 import printing.Highlighting._
 import printing.Formatting
 
@@ -678,4 +676,33 @@ object messages {
            |$fixedVarInAlternative""".stripMargin
     }
   }
+
+  case class IdentifierExpected()(implicit ctx: Context) extends Message(24) {
+    val kind = "Syntax"
+    val msg = "identifier expected"
+
+    val typeExplicitly = "def sum(): Int = {...}"
+
+    val typeImplicit = "def sum() = {...}"
+
+    val explanation = {
+      hl"""|When using type identifiers, you should pass a valid one.
+           |Because of Scala's stronger type, you can fix this issue either
+           |passing a valid type identifier or you can omit it, so the compiler can infer it for you.
+           |
+           |Let's write a function called ${"sum"}
+           |
+           |Here we explicitly pass a valid type identifier, in this case ${"Int"} for the function:
+           |
+           |$typeExplicitly
+           |
+           |But you also have the option to omit it completely.
+           |
+           |$typeImplicit
+           |
+           |This time the compiler will infer this type for you.
+           |
+           |""".stripMargin
+    }
+  }
 }