Give "did you mean ...?" hints also for simple identifiers #18747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Only show accessible members
2. Show several alternatives if they are at same distance. Unlike Scala 2,
we do not show alternatives at larger distance. I fear that would produce
more noise than signal.
Fixes scala#17067
bishabosha
reviewed
Oct 23, 2023
som-snytt
reviewed
Oct 23, 2023
| | | ||
| | longer explanation available when compiling with `-explain` | ||
| -- [E006] Not Found Error: tests/neg/yimports-stable/C_2.scala:4:16 ---------------------------------------------------- | ||
| 4 | val v: Numb = magic // error // error | ||
| | ^^^^^ | ||
| | Not found: magic | ||
| | Not found: magic - did you mean main? |
There was a problem hiding this comment.
in case you wondered if @main is too much magic
If scala.annotation were opened by @syntax, then annotations there would autocomplete only under @ma[etc].
There was a problem hiding this comment.
Yes, I like that and did propose it at some point. Failed to convince @sjrd though.
Co-authored-by: Jamie Thompson <bishbashboshjt@gmail.com>
bishabosha
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18682
Fixes #17067