Fix #2369: Should warn when ignoring command line flags #2590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
May 29, 2017
|
@typeness, your current implementation fails compilation in case flag is passed twice. And this is why the tests failed. Did you intend to use |
|
Ok I will change that to warn instead. I was not sure whether this should fail or warn so I followed felixmulder's comment. |
added 2 commits
May 31, 2017 15:40
|
Any feedback? |
felixmulder
approved these changes
Jun 2, 2017
There was a problem hiding this comment.
Sorry for the delay, we've been pretty pre-occupied during this past week.
LGTM, thanks @typeness! 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.