Skip to content

Fix #2369: Should warn when ignoring command line flags #2590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 2, 2017
Merged

Fix #2369: Should warn when ignoring command line flags #2590

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e32eb2d
Fix #2369: Should warn when ignoring command line flags
May 29, 2017
42002df
Change fail to warn
May 31, 2017
08f1233
Properly emit warning
May 31, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions compiler/src/dotty/tools/dotc/config/Settings.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,8 @@ object Settings {
depends: List[(Setting[_], Any)] = Nil,
propertyClass: Option[Class[_]] = None)(private[Settings] val idx: Int) {

private var changed: Boolean = false

def withAbbreviation(abbrv: String): Setting[T] =
copy(aliases = aliases :+ abbrv)(idx)

Expand Down Expand Up @@ -111,8 +113,14 @@ object Settings {

def tryToSet(state: ArgsSummary): ArgsSummary = {
val ArgsSummary(sstate, arg :: args, errors, warnings) = state
def update(value: Any, args: List[String]) =
ArgsSummary(updateIn(sstate, value), args, errors, warnings)
def update(value: Any, args: List[String]) = {
if (changed) {
ArgsSummary(updateIn(sstate, value), args, errors, warnings :+ s"Flag $name set repeatedly")
} else {
changed = true
ArgsSummary(updateIn(sstate, value), args, errors, warnings)
}
}
def fail(msg: String, args: List[String]) =
ArgsSummary(sstate, args, errors :+ msg, warnings)
def missingArg =
Expand Down