-
Notifications
You must be signed in to change notification settings - Fork 0
Improve Interactive client #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! I did a little bit of browsing around. Really looking forward to using these improvements!
Some of this won’t work for larger databases/entries. For example, I can’t scroll in the »Select version x« button list view. I think it would be nice to have a text field there to input the selected number instead. It is common that thousands of versions exist for a key.
Also I saw in the code that up to 1e6 keys are requested for the key list. I think that is too much, it will take a long time. Please list only, say, 5000 and then print that there may be more keys. If so, the user will have to refine their prefix.
I can give you access to a large fossilDB to test this. Talk to me about credentials.
Actually, the limit is for 1e6 requests but this can be tuned down of course when met with reality. However, the fetching should run asynchronously so not slow it down, but that is also not tested on real data. |
fce854c to
9541c4e
Compare
|
These are some great improvements :) I think with the latest commits the perfrmance of the record explorer is acceptable. I’m wondering if we can further improve the Browser’s performance, though. In e.g. the skeleton collection, interacting with the list, e.g. pgdn, seems very slow. I’d rather relinquish the number of versions column if that could improve the performance. Maybe you could go for some more experiments there? |
|
Added the performance mode. I think the main problems are the many redraws because of the async updates. These are disabled with performance mode. The skeletons collection should now be usable. |
6727d0b to
3f3fea8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely better! It still froze a bunch on very-many-version records but those are relatively rare and i’d consider it usable.
Offsite 2025
New Features
TODOS