Fix screenshot tests #8575
Fix screenshot tests #8575
Conversation
📝 WalkthroughWalkthroughThe Node.js version specified in two GitHub Actions workflow files for nightly test pipelines was updated from version 18 to version 22. This change affects the environment setup step, ensuring that all subsequent steps in the workflows, such as dependency installation and test execution, now utilize Node.js 22. No other aspects of the workflows, such as logic or error handling, were modified. Changes
Possibly related PRs
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/wkorg-nightly.yaml (1)
20-20: Use semver range for Node.js version
To ensure the workflow always picks the latest patch for Node.js 22, consider specifyingnode-version: '22.x'instead of a bare22.🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 20-20: wrong indentation: expected 10 but found 12
(indentation)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/nightly.yml(1 hunks).github/workflows/wkorg-nightly.yaml(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
.github/workflows/wkorg-nightly.yaml
[warning] 20-20: wrong indentation: expected 10 but found 12
(indentation)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: nightly-screenshot-tests
- GitHub Check: backend-tests
- GitHub Check: build-smoketest-push
🔇 Additional comments (1)
.github/workflows/nightly.yml (1)
44-47: Upgrade Node.js version in CI workflow
The change from Node.js 18 to 22 in the setup step aligns the nightly screenshot tests with the required runtime and keeps it consistent with the other pipeline.
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 18 | ||
| node-version: 22 | ||
|
|
There was a problem hiding this comment.
Fix indentation for the node-version field
The node-version: 22 line is over-indented by two extra spaces, which will break the YAML structure and prevent the configuration from being applied.
- - uses: actions/setup-node@v4
- with:
- node-version: 22
+ - uses: actions/setup-node@v4
+ with:
+ node-version: 22📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - uses: actions/setup-node@v4 | |
| with: | |
| node-version: 18 | |
| node-version: 22 | |
| - uses: actions/setup-node@v4 | |
| with: | |
| node-version: 22 |
🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 20-20: wrong indentation: expected 10 but found 12
(indentation)
Fix screenshot tests by configuring the right node version (v22+).
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)