Skip to content

Conversation

@Torch3333
Copy link
Contributor

@Torch3333 Torch3333 commented Jun 25, 2025

Description

Add sample configuration and docker-compose setup for Db2.
This PR accompanies the documentation update for the Db2 adapter, see https://github.com/scalar-labs/docs-internal-scalardb/pull/1345

Related issues and/or PRs

Changes made

Add configuration and docker-compose setup for Db2.

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @Torch3333, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the project's database support by integrating Db2. It provides the necessary Docker Compose configurations to run a Db2 instance locally and includes example property files to guide users on how to connect ScalarDB applications to Db2. Additionally, it ensures all relevant ScalarDB dependencies and images are updated to the latest 3.16.0 version, bringing in any new features or fixes from that release.

Highlights

  • Db2 Docker Integration: Added Docker Compose service definitions for Db2 Community Edition to scalardb-cluster-standalone-mode, scalardb-kotlin-sample, and scalardb-sample projects. This enables easy local setup of a Db2 instance, exposing port 50000 and configuring necessary environment variables for a sample database.
  • Db2 Configuration Examples: Included commented-out configuration properties for connecting ScalarDB to a Db2 database in scalardb-cluster-standalone-mode/scalardb-cluster-node.properties, scalardb-kotlin-sample/database.properties, and scalardb-sample/database.properties. These provide a clear template for users to switch from Cassandra to Db2.
  • ScalarDB Dependency Update: Updated the scalardb library dependency from version 3.13.0 to 3.16.0 across scalardb-kotlin-sample and scalardb-sample projects. Correspondingly, the scalardb-cluster-node image in scalardb-cluster-standalone-mode was also updated to 3.16.0.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces Db2 support by adding its configuration to Docker Compose and properties files. It also updates the scalardb dependency version. The use of privileged: true in the Docker Compose files poses a security risk, and the Db2 connection string in scalardb-cluster-standalone-mode properties uses localhost instead of the Docker service name.

@Torch3333 Torch3333 self-assigned this Jun 26, 2025
@Torch3333 Torch3333 marked this pull request as ready for review June 26, 2025 00:48
@Torch3333 Torch3333 requested review from a team, brfrn169, feeblefakie and komamitsu and removed request for a team June 26, 2025 00:48
Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Torch3333 Torch3333 added the enhancement New feature or request label Jun 27, 2025
Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit d316464 into main Jun 27, 2025
32 checks passed
@feeblefakie feeblefakie deleted the sample_with_db2 branch June 27, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants