Update CI to fix issues of SQL Server integration test #1567
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,79 @@ | ||
| #!/bin/bash | ||
| set -u | ||
|
Contributor
Author
There was a problem hiding this comment. To continue the script (to run retry) even after |
||
|
|
||
| # Get container name and password from arguments | ||
| SQL_SERVER_CONTAINER_NAME=$1 | ||
| SQL_SERVER_PASSWORD=$2 | ||
| MAX_RETRY_COUNT=$3 | ||
| RETRY_INTERVAL=$4 | ||
| COUNT=0 | ||
|
|
||
| echo "INFO: Creating no superuser start." | ||
|
|
||
| # A SQL Server container takes a few seconds to start SQL Server process | ||
| # in the container. So, first, we wait ${RETRY_INTERVAL} seconds before | ||
| # we run the `sqlcmd` command in the container. | ||
| echo "INFO: Sleep ${RETRY_INTERVAL} seconds to wait for SQL Server start." | ||
|
|
||
| while [[ ${COUNT} -lt ${MAX_RETRY_COUNT} ]] | ||
| do | ||
| sleep ${RETRY_INTERVAL} | ||
|
|
||
| echo "INFO: Retry count: ${COUNT}" | ||
|
|
||
| docker exec -t ${SQL_SERVER_CONTAINER_NAME} /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P ${SQL_SERVER_PASSWORD} -d master -Q "SELECT 1" | ||
| if [[ $? -eq 0 ]]; then | ||
| break | ||
| else | ||
| echo "INFO: sqlcmd command failed. Will retry after ${RETRY_INTERVAL} seconds." | ||
| fi | ||
|
|
||
| COUNT=$((COUNT + 1)) | ||
|
|
||
| if [[ ${COUNT} -eq ${MAX_RETRY_COUNT} ]]; then | ||
| echo "ERROR: sqlcmd command failed ${MAX_RETRY_COUNT} times. Please check your configuration." >&2 | ||
| exit 1 | ||
| fi | ||
| done | ||
|
|
||
| echo "INFO: sqlcmd command succeeded. Continue creating no superuser." | ||
|
Comment on lines
+18
to
+39
Contributor
Author
There was a problem hiding this comment. First, this script checks whether it can access SQL Server or not by using |
||
|
|
||
| # Create login | ||
| echo "INFO: Create login start" | ||
| docker exec -t ${SQL_SERVER_CONTAINER_NAME} /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P ${SQL_SERVER_PASSWORD} -d master -Q "CREATE LOGIN no_superuser WITH PASSWORD = 'no_superuser_password', DEFAULT_DATABASE = master , CHECK_POLICY = OFF, CHECK_EXPIRATION = OFF" | ||
| echo "INFO: Create login end" | ||
|
|
||
| # Create database | ||
| echo "INFO: Create database start" | ||
| docker exec -t ${SQL_SERVER_CONTAINER_NAME} /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P ${SQL_SERVER_PASSWORD} -d master -Q "CREATE DATABASE test_db COLLATE Japanese_BIN2" | ||
|
Contributor
Author
There was a problem hiding this comment. This script set collation |
||
| echo "INFO: Create database end" | ||
|
|
||
| # Create no_superuser | ||
| echo "INFO: Create no_superuser start" | ||
| docker exec -t ${SQL_SERVER_CONTAINER_NAME} /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P ${SQL_SERVER_PASSWORD} -d test_db -Q "CREATE USER no_superuser FOR LOGIN no_superuser" | ||
| echo "INFO: Create no_superuser end" | ||
|
|
||
| # Add roles | ||
| echo "INFO: Add role db_ddladmin start" | ||
| docker exec -t ${SQL_SERVER_CONTAINER_NAME} /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P ${SQL_SERVER_PASSWORD} -d test_db -Q "EXEC sp_addrolemember @rolename = 'db_ddladmin', @membername = 'no_superuser'" | ||
| echo "INFO: Add role db_ddladmin end" | ||
|
|
||
| echo "INFO: Add role db_datawriter start" | ||
| docker exec -t ${SQL_SERVER_CONTAINER_NAME} /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P ${SQL_SERVER_PASSWORD} -d test_db -Q "EXEC sp_addrolemember @rolename = 'db_datawriter', @membername = 'no_superuser'" | ||
| echo "INFO: Add role db_datawriter end" | ||
|
|
||
| echo "INFO: Add role db_datareader start" | ||
| docker exec -t ${SQL_SERVER_CONTAINER_NAME} /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P ${SQL_SERVER_PASSWORD} -d test_db -Q "EXEC sp_addrolemember @rolename = 'db_datareader', @membername = 'no_superuser'" | ||
| echo "INFO: Add role db_datareader end" | ||
|
|
||
| # Check the collation of test_db (for debugging purposes) | ||
| echo "INFO: Check collation start" | ||
| docker exec -t ${SQL_SERVER_CONTAINER_NAME} /opt/mssql-tools/bin/sqlcmd -S localhost -U no_superuser -P no_superuser_password -d test_db -Q "SELECT name, collation_name FROM sys.databases" -W | ||
|
Contributor
Author
There was a problem hiding this comment. For debugging purposes, I added the SQL command to see the database collation settings. |
||
| echo "INFO: Check collation end" | ||
|
|
||
| # Check if no_superuser can access SQL Server (for debugging purposes) | ||
| echo "INFO: SELECT @@version start" | ||
| docker exec -t ${SQL_SERVER_CONTAINER_NAME} /opt/mssql-tools/bin/sqlcmd -S localhost -U no_superuser -P no_superuser_password -d test_db -Q "SELECT @@version" | ||
| echo "INFO: SELECT @@version end" | ||
|
|
||
| echo "INFO: Creating no superuser succeeded." | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I set the collation by the
CREATE DATABASEin the script. So, we can remove this configuration from here.