Skip to content

Conversation

@komamitsu
Copy link
Contributor

@komamitsu komamitsu commented Jun 18, 2024

Description

We've already moved to the Cosmo DB emulator for the integration tests. As a result, scalardb.cosmos.database_prefix is no longer needed (see #1909 (review)). This PR removes it as a follow-up PR.

Related issues and/or PRs

Changes made

  • Remove implementations that use scalardb.cosmos.database_prefix property

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

None

Release notes

N/A

@komamitsu komamitsu self-assigned this Jun 19, 2024
@komamitsu komamitsu added the github_actions Pull requests that update GitHub Actions code label Jun 19, 2024
Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Contributor

@Torch3333 Torch3333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie
Copy link
Contributor

@komamitsu Sorry, can you fix the conflicts? 🙇

@komamitsu komamitsu merged commit 1cec5d3 into master Jun 20, 2024
@komamitsu komamitsu deleted the remove-unnecessary-cosmosdb-property branch June 20, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants