-
Notifications
You must be signed in to change notification settings - Fork 40
Remove unnecessary scalardb.cosmos.database_prefix property
#1918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
brfrn169
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Torch3333
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
feeblefakie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
|
@komamitsu Sorry, can you fix the conflicts? 🙇 |
Description
We've already moved to the Cosmo DB emulator for the integration tests. As a result,
scalardb.cosmos.database_prefixis no longer needed (see #1909 (review)). This PR removes it as a follow-up PR.Related issues and/or PRs
Changes made
scalardb.cosmos.database_prefixpropertyChecklist
Additional notes (optional)
None
Release notes
N/A