Skip to content

Reduce the number of concurrent DDLs from 10 to 1 for Cosmos DB in the integration tests #1920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 19, 2024
Merged

Reduce the number of concurrent DDLs from 10 to 1 for Cosmos DB in the integration tests #1920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e93f93e
Reduce the # of concurrent DDL to 3 for Cosmos DB
komamitsu Jun 18, 2024
93c536c
Less concurrency
komamitsu Jun 18, 2024
fe321b1
Configure DDL concurrency
komamitsu Jun 19, 2024
76127f8
Merge branch 'master' into reduce-cosmosdb-ddl-concurrency
brfrn169 Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...ation-test/java/com/scalar/db/storage/cosmos/CosmosCrossPartitionScanIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,16 @@ protected Map<String, String> getCreationOptions() {
return CosmosEnv.getCreationOptions();
}

@Override
protected int getThreadNum() {
Copy link
Collaborator

@brfrn169 brfrn169 Jun 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we override the isParallelDdlSupported() method instead of this? Or we might be able to remove the isParallelDdlSupported() method and use getThreadNum() instead for the sake of consistency.

Copy link
Contributor Author

@komamitsu komamitsu Jun 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brfrn169 Good point! Actually I noticed the same and created a branch to remove executeDdls() and isParallelDdlSupported() a17d246.

I'll create a PR with the change for only branches 3 and master that contain those unnecessary methods (reducing concurrency for Cosmos DB integration test is needed for all the release and support branches)

return 3;
}

@Override
protected boolean isParallelDdlSupported() {
return false;
}

@Test
@Override
@Disabled("Cross partition scan with ordering is not supported in Cosmos DB")
Expand Down
5 changes: 5 additions & 0 deletions ...est/java/com/scalar/db/storage/cosmos/CosmosMultipleClusteringKeyScanIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,11 @@ protected int getThreadNum() {
return 3;
}

@Override
protected boolean isParallelDdlSupported() {
return false;
}

@Override
protected Map<String, String> getCreationOptions() {
return CosmosEnv.getCreationOptions();
Expand Down
5 changes: 5 additions & 0 deletions ...ion-test/java/com/scalar/db/storage/cosmos/CosmosMultiplePartitionKeyIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@ protected int getThreadNum() {
return 3;
}

@Override
protected boolean isParallelDdlSupported() {
return false;
}

@Override
protected Map<String, String> getCreationOptions() {
return CosmosEnv.getCreationOptions();
Expand Down