Skip to content

Conversation

@Torch3333
Copy link
Contributor

@Torch3333 Torch3333 commented Jun 24, 2024

Description

Integration tests fail when using Java 21 as the runtime because the net.bytebuddy:byte-buddy library current version is incompatible with Java 21. This library is a transitive dependency of AsserJ and Mockito.
This PR updates this dependency to a version that supports Java 21.

Related issues and/or PRs

N/A

Changes made

I updated AsserJ so that its transitive dependency net.bytebuddy:byte-buddy is updated to a version that supports Java 21.

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

Release notes

N/A

@Torch3333 Torch3333 self-assigned this Jun 24, 2024
@Torch3333 Torch3333 changed the base branch from master to 3.11 June 24, 2024 00:58
@Torch3333 Torch3333 changed the title [3.11] For runtime error in integration test when using Java 21 as runtime [3.7~3.11] Fix error in integration test with Java 21 as runtime Jun 24, 2024
@Torch3333 Torch3333 marked this pull request as ready for review June 24, 2024 01:37
Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants