-
Notifications
You must be signed in to change notification settings - Fork 40
Backport to branch(3) : Bump the dependencies group with 6 updates #2823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: brfrn169 <brfrn169@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @feeblefakie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request is an automated backport that primarily focuses on updating various project dependencies to their newer versions. A significant part of the change involves refactoring the JUnit 5 dependency declarations across multiple modules to adopt the JUnit Bill of Materials (BOM) for improved consistency and simplified management.
Highlights
- Dependency Version Bumps: I've updated several dependency versions in
build.gradle, includingazureCosmosVersionfrom4.71.0to4.72.0,sqliteDriverVersionfrom3.50.1.0to3.50.2.0,mariadDbDriverVersionfrom3.5.3to3.5.4, andjunitVersionfrom5.11.4to5.13.2. - JUnit 5 Dependency Management Refactor: The way JUnit 5 dependencies are declared has been refactored across
core/build.gradle,data-loader/build.gradle,integration-test/build.gradle, andschema-loader/build.gradle. The previous explicitjunit-jupiter-api,junit-jupiter-params, andjunit-jupiter-enginedeclarations have been replaced with a more streamlined approach usingplatform("org.junit:junit-bom:${junitVersion}"),org.junit.jupiter:junit-jupiter, andorg.junit.platform:junit-platform-launcher.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is an automated backport that updates several dependencies, including Azure Cosmos, SQLite, MariaDB, and JUnit. It also refactors the JUnit dependency declarations across multiple Gradle build files to use the recommended BOM and aggregator artifact approach. This simplifies the build configuration and ensures consistent JUnit versions. The changes look good, but I've pointed out a minor typo in a variable name for a dependency version that is being updated.
| yugabyteDriverVersion = '42.7.3-yb-4' | ||
| db2DriverVersion= '12.1.2.0' | ||
| mariadDbDriverVersion = '3.5.3' | ||
| mariadDbDriverVersion = '3.5.4' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be a typo in this variable name. It's likely intended to be mariaDbDriverVersion instead of mariadDbDriverVersion.
While this is a pre-existing issue, it would be good to correct it for better maintainability. If you decide to fix it, remember to update its usage in core/build.gradle as well.
mariaDbDriverVersion = '3.5.4'
This is an automated backport of the following:
Please merge this PR after all checks have passed.