-
Notifications
You must be signed in to change notification settings - Fork 40
Pass necessary secrets to release workflow #2870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the GitHub workflow configuration to pass the correct secrets for Maven Central publishing. The change addresses a missing secrets configuration issue from a previous PR that prevented proper artifact uploading during the release process.
Key changes:
- Replaces old signing-related secrets with Maven Central-specific secrets in the workflow interface
- Updates the release workflow to pass the new Maven Central secrets to the upload-artifacts workflow
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/upload-artifacts.yaml |
Updates the workflow interface to define Maven Central secrets instead of generic signing secrets |
.github/workflows/release.yaml |
Updates the workflow call to pass the new Maven Central secrets to the upload-artifacts workflow |
jnmt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
komamitsu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
Torch3333
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
feeblefakie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Description
In #2849, I forgot to pass the necessary secrets to the
upload-artifactsworkflow. This PR addresses the issue.Related issues and/or PRs
Changes made
Checklist
Additional notes (optional)
N/A
Release notes
N/A