Skip to content

Conversation

@brfrn169
Copy link
Collaborator

Description

When publishing artifacts to Maven Central using the jreleaserDeploy task, we encountered an OOM error. To address this, this PR increases the heap size allocated to the jreleaserDeploy task.

Related issues and/or PRs

N/A

Changes made

  • Increased the heap size for the jreleaserDeploy task.

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • I have considered whether similar issues could occur in other products, components, or modules if this PR is for bug fixes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

N/A

@brfrn169 brfrn169 requested a review from Copilot July 16, 2025 07:59
@brfrn169 brfrn169 self-assigned this Jul 16, 2025
@brfrn169 brfrn169 added improvement github_actions Pull requests that update GitHub Actions code labels Jul 16, 2025
@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR increases the heap size for the jreleaserDeploy Gradle task in the CI workflow to prevent out-of-memory errors during artifact publication.

  • Adds a JVM max heap setting (-Xmx4g) to the jreleaserDeploy step.
Comments suppressed due to low confidence (2)

.github/workflows/upload-artifacts.yaml:56

  • [nitpick] Add a comment above this step explaining that the heap size is increased to avoid OOM errors when publishing artifacts to Maven Central.
        run: ./gradlew jreleaserDeploy -Dorg.gradle.jvmargs="-Xmx4g"

.github/workflows/upload-artifacts.yaml:56

  • [nitpick] Consider moving the JVM argument into a shared configuration (e.g., gradle.properties or an environment variable) so the heap size can be adjusted globally without editing the workflow file.
        run: ./gradlew jreleaserDeploy -Dorg.gradle.jvmargs="-Xmx4g"

@brfrn169 brfrn169 requested a review from jnmt July 16, 2025 08:17
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Copy link
Contributor

@jnmt jnmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Contributor

@Torch3333 Torch3333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@brfrn169 brfrn169 merged commit c0da43a into master Jul 17, 2025
106 of 108 checks passed
@brfrn169 brfrn169 deleted the increase-heap-size-for-jreleaserDeploy-task branch July 17, 2025 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants