-
Notifications
You must be signed in to change notification settings - Fork 40
Increase heap size for jreleaserDeploy task #2877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR increases the heap size for the jreleaserDeploy Gradle task in the CI workflow to prevent out-of-memory errors during artifact publication.
- Adds a JVM max heap setting (
-Xmx4g) to thejreleaserDeploystep.
Comments suppressed due to low confidence (2)
.github/workflows/upload-artifacts.yaml:56
- [nitpick] Add a comment above this step explaining that the heap size is increased to avoid OOM errors when publishing artifacts to Maven Central.
run: ./gradlew jreleaserDeploy -Dorg.gradle.jvmargs="-Xmx4g"
.github/workflows/upload-artifacts.yaml:56
- [nitpick] Consider moving the JVM argument into a shared configuration (e.g.,
gradle.propertiesor an environment variable) so the heap size can be adjusted globally without editing the workflow file.
run: ./gradlew jreleaserDeploy -Dorg.gradle.jvmargs="-Xmx4g"
feeblefakie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
komamitsu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
jnmt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Torch3333
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Description
When publishing artifacts to Maven Central using the
jreleaserDeploytask, we encountered an OOM error. To address this, this PR increases the heap size allocated to thejreleaserDeploytask.Related issues and/or PRs
N/A
Changes made
jreleaserDeploytask.Checklist
Additional notes (optional)
N/A
Release notes
N/A