Skip to content

Conversation

@feeblefakie
Copy link
Contributor

This is an automated backport of the following:

Please merge this PR after all checks have passed.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @feeblefakie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is an automated backport aimed at modernizing the codebase by removing deprecated API usages across various modules. The primary impact is to update Key object instantiations, Scan.Ordering creations, and MutationCondition constructions to use newer, recommended factory methods and builders, ensuring compatibility and adherence to updated API guidelines.

Highlights

  • Key Constructor Replacement: Replaced direct Key constructors with static factory methods like Key.ofInt, Key.ofText, Key.ofBlob, and Key.of for improved clarity and type safety.
  • Conditional Expression Modernization: Updated ConditionalExpression.getName() calls to ConditionalExpression.getColumn().getName() to align with the revised column naming conventions.
  • Scan Ordering Factory Methods: Switched from new Scan.Ordering() to Scan.Ordering.asc() and Scan.Ordering.desc() for creating scan orderings.
  • Mutation Condition Builder Adoption: Replaced direct instantiations of PutIfNotExists, PutIfExists, DeleteIfExists, PutIf, and DeleteIf with their respective ConditionBuilder factory methods.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a backport that removes deprecated API usages throughout the codebase. The changes are extensive and consistently apply modern, more readable APIs, such as factory methods for Key and Scan.Ordering, and builders for conditions. This is a great improvement for maintainability. I've found a couple of issues in SnapshotTest.java where the refactoring seems to have inadvertently altered the test logic by changing key values. My review includes suggestions to fix these issues.

@brfrn169 brfrn169 merged commit d4036df into 3 Aug 19, 2025
56 checks passed
@brfrn169 brfrn169 deleted the 3-pull-2947 branch August 19, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants