-
Notifications
You must be signed in to change notification settings - Fork 40
[CI] Disable fail-fast strategy for integration test jobs #3042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR disables the fail-fast strategy for integration test jobs in the CI workflow to allow all test variants to run to completion even if one fails.
- Adds
fail-fast: falseto the matrix strategy configuration for all integration test jobs - Ensures both default and group commit test variants run independently without early termination
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
komamitsu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
brfrn169
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Description
For integration tests in CI, we have two variants — default and group commit — for each storage integration test. If one of the variants fails, the other automatically fails without completing the tests. We disable this behavior so all integration tests can run to completion.
Related issues and/or PRs
Changes made
Checklist
Additional notes (optional)
Release notes
N/A