Skip to content

Conversation

@Torch3333
Copy link
Contributor

@Torch3333 Torch3333 commented Oct 14, 2025

Description

For integration tests in CI, we have two variants — default and group commit — for each storage integration test. If one of the variants fails, the other automatically fails without completing the tests. We disable this behavior so all integration tests can run to completion.

Related issues and/or PRs

Changes made

  • Set fail-false to false in the matrix strategy for integration test jobs

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • I have considered whether similar issues could occur in other products, components, or modules if this PR is for bug fixes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

Provide any additional information or notes that may be relevant to the reviewers or stakeholders.

Release notes

N/A

@Torch3333 Torch3333 self-assigned this Oct 14, 2025
@Torch3333 Torch3333 changed the title [CI] Disable fail-fast strategy for integration test [CI] Disable fail-fast strategy for integration test jobs Oct 14, 2025
@Torch3333 Torch3333 requested a review from Copilot October 14, 2025 07:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR disables the fail-fast strategy for integration test jobs in the CI workflow to allow all test variants to run to completion even if one fails.

  • Adds fail-fast: false to the matrix strategy configuration for all integration test jobs
  • Ensures both default and group commit test variants run independently without early termination

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Torch3333 Torch3333 requested review from a team, brfrn169, feeblefakie and komamitsu and removed request for a team October 14, 2025 07:46
@Torch3333 Torch3333 mentioned this pull request Oct 14, 2025
7 tasks
@Torch3333 Torch3333 marked this pull request as ready for review October 14, 2025 07:47
Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants