Skip to content

Conversation

@feeblefakie
Copy link
Contributor

This is an automated request for a manual backport of the following:

  1. Resolve any conflicts that occur during the cherry-picking process.
git fetch origin &&
git checkout 3-pull-3040 &&
git cherry-pick --no-rerere-autoupdate -m1 6abf46dad6728060367db84e4c38c4441bd743f1
  1. Push the changes.
  2. Merge this PR after all checks have passed.

Thank you!

@KodaiD
Copy link
Contributor

KodaiD commented Oct 14, 2025

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a backport to add a wait for cache expiry in several integration tests. The changes involve setting the metadata cache expiration to 1 second in test environments and adding a 1-second sleep after schema-altering operations to ensure the cache is updated. This is intended to make the tests more stable. The changes also include some nice refactoring of try-with-resources blocks in test methods, improving code clarity and resource management. My main feedback is about the sleep duration, which might be too tight and could lead to flaky tests.

@brfrn169 brfrn169 marked this pull request as ready for review October 14, 2025 08:54
@brfrn169 brfrn169 merged commit 4601164 into 3 Oct 14, 2025
102 of 108 checks passed
@brfrn169 brfrn169 deleted the 3-pull-3040 branch October 14, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants