Backport to branch(3) : Replace ScalarDbMode with core TransactionMode for clarity

[feeblefakie]

This is an automated backport of the following:

• Original PR: Replace ScalarDbMode with core TransactionMode for clarity #3181
• Backported commit: 38b2009

Please merge this PR after all checks have passed.

[gemini-code-assist]

Summary of Changes

Hello @feeblefakie, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request backports a significant refactoring to the ScalarDB data loader's transaction mode handling. The primary goal is to enhance clarity and maintainability by introducing a new TransactionMode enum in the core module, which explicitly defines transactional behaviors. Concurrently, the older ScalarDbMode enum has been deprecated and relocated to the CLI module to preserve backward compatibility for existing command-line interfaces. This change ensures that the internal data loading processes operate with a more precise and future-proof understanding of transaction semantics.

Highlights

• Deprecation of ScalarDbMode: The ScalarDbMode enum has been deprecated and moved from the core module to the CLI module. It is now explicitly marked for removal in a future release (4.0.0) and is maintained solely for CLI backward compatibility.
• Introduction of TransactionMode: A new TransactionMode enum has been introduced in the core module, defining SINGLE_CRUD and CONSENSUS_COMMIT modes. This provides a clearer and more explicit way to specify transaction behavior within the data loader's core logic.
• Refactoring of Import Logic: The data import mechanisms, including ImportManager and ImportProcessor, have been refactored to utilize the new TransactionMode. This involves updating method signatures, internal logic, and Javadoc comments to reflect the new terminology and ensure consistency.
• CLI Integration and Conversion: The CLI ImportCommand now includes a conversion utility to map the deprecated ScalarDbMode values from the command line to the new TransactionMode values used internally by the core modules, ensuring a smooth transition and backward compatibility for CLI users.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the data loader to replace the ScalarDbMode enum with a more descriptive TransactionMode enum. The changes are well-executed, improving code clarity by using SINGLE_CRUD and CONSENSUS_COMMIT modes. The old ScalarDbMode is correctly deprecated for backward compatibility in the CLI. My review includes a few suggestions to improve documentation, such as correcting a minor typo and clarifying the parallel processing behavior in the Javadoc of ImportProcessor to match the implementation.