Backport to branch(3) : For Oracle, allow importing a table with NUMBER(1) data type to a ScalarDB BOOLEAN

[feeblefakie]

This is an automated backport of the following:

• Original PR: For Oracle, allow importing a table with NUMBER(1) data type to a ScalarDB BOOLEAN #3239
• Backported commit: 1935d4e

Please merge this PR after all checks have passed.

[gemini-code-assist]

Summary of Changes

Hello @feeblefakie, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is an automated backport that enhances ScalarDB's JDBC storage connector for Oracle. It introduces the necessary logic and testing to ensure that Oracle's NUMBER(1) data type can be correctly interpreted and mapped to ScalarDB's BOOLEAN type during schema import operations, improving compatibility and data type handling for Oracle databases.

Highlights

• Oracle NUMBER(1) to BOOLEAN Mapping: Enabled the correct mapping of Oracle's NUMBER(1) data type to ScalarDB's BOOLEAN type during table import operations.
• Integration Test Coverage: Added a new integration test case to JdbcAdminImportTestUtils to validate the NUMBER(1) to BOOLEAN mapping for Oracle.
• Internal Data Type Mapping Update: Updated the internal DATA_TYPE_MAP in RdbEngineTest to reflect the new NUMBER(1) to BOOLEAN mapping for Oracle, alongside its default BIGINT mapping.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a backport to allow importing an Oracle table with a NUMBER(1) data type column as a ScalarDB BOOLEAN type. The changes are well-implemented and tested. The core logic is updated in RdbEngineOracle to handle this specific data type mapping during import, but only when the user explicitly overrides the column type to BOOLEAN. The pull request also includes corresponding unit tests in RdbEngineTest and integration tests in JdbcAdminImportTestUtils to ensure the new functionality works as expected and doesn't introduce regressions. The changes are correct and the code quality is good. I have no further recommendations.