Backport to branch(3.17) : For Oracle, allow importing a table with NUMBER(1) data type to a ScalarDB BOOLEAN

[feeblefakie]

This is an automated backport of the following:

• Original PR: For Oracle, allow importing a table with NUMBER(1) data type to a ScalarDB BOOLEAN #3239
• Backported commit: 1935d4e

Please merge this PR after all checks have passed.

[gemini-code-assist]

Summary of Changes

Hello @feeblefakie, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request backports a critical enhancement to the 3.17 branch, enabling ScalarDB to correctly interpret Oracle's NUMBER(1) data type as a BOOLEAN during table import operations. This ensures better compatibility and data type fidelity when integrating with Oracle databases, particularly for columns intended to represent boolean values. The changes include core logic adjustments and corresponding test case additions to validate the new mapping behavior.

Highlights

• Oracle NUMBER(1) to BOOLEAN Mapping: Implemented logic to correctly map Oracle's NUMBER(1) data type to ScalarDB's BOOLEAN type during table import, specifically when an override is specified.
• Data Type Mapping Refinement: Updated the RDB engine's data type mapping for Oracle to distinguish between NUMBER(1) as BOOLEAN (with override) and NUMBER(1) as BIGINT (default behavior without override).
• Integration Test Enhancement: Added integration test cases to verify the proper handling and mapping of Oracle NUMBER(1) columns to ScalarDB BOOLEAN during the import process.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request backports a change to allow importing an Oracle table column of type NUMBER(1) as a ScalarDB BOOLEAN type. The change is implemented in RdbEngineOracle by checking for this specific case when an override to BOOLEAN is provided. The pull request also includes corresponding updates to unit tests in RdbEngineTest and integration tests in JdbcAdminImportTestUtils to verify the new functionality and ensure existing behavior is not affected. The changes are correct and well-tested.