-
Notifications
You must be signed in to change notification settings - Fork 3
Backport to branch(3) : Add release flows for HashStore and TableStore #272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @feeblefakie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This backport introduces comprehensive release flows for the ScalarDL HashStore and TableStore Java client SDKs. It establishes Maven publishing configurations, standardizes naming conventions across various build and command-line components, and refines the TableStore client API by removing an unused method. These changes are crucial for streamlining the release process and improving the consistency and maintainability of the client SDKs. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request backports changes to add release flows for HashStore and TableStore. The changes include adding Maven publishing configurations, updating Javadoc generation, and standardizing application names. The changes are mostly correct, but I've found a potential issue in the Gradle build scripts where the logic to apply publishing configuration is fragile and might not work as expected depending on how Gradle is invoked. I've provided suggestions to make it more robust.
| if (!project.gradle.startParameter.taskNames.isEmpty() && | ||
| (project.gradle.startParameter.taskNames[0].endsWith('publish') || | ||
| project.gradle.startParameter.taskNames[0].endsWith('publishToMavenLocal'))) { | ||
| apply from: 'archive.gradle' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The condition project.gradle.startParameter.taskNames[0].endsWith(...) is fragile. It only checks the first task specified on the command line. If other tasks are run before the publish task (e.g., gradle clean publish), this condition will be false, and the publishing configuration will not be applied.
To make this more robust, you should check if any of the requested tasks is a publish task. This will correctly detect the intention to publish regardless of other tasks on the command line.
if (project.gradle.startParameter.taskNames.any { it.endsWith('publish') || it.endsWith('publishToMavenLocal') }) {
apply from: 'archive.gradle'
}
| if (!project.gradle.startParameter.taskNames.isEmpty() && | ||
| (project.gradle.startParameter.taskNames[0].endsWith('publish') || | ||
| project.gradle.startParameter.taskNames[0].endsWith('publishToMavenLocal'))) { | ||
| apply from: 'archive.gradle' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The condition project.gradle.startParameter.taskNames[0].endsWith(...) is fragile. It only checks the first task specified on the command line. If other tasks are run before the publish task (e.g., gradle clean publish), this condition will be false, and the publishing configuration will not be applied.
To make this more robust, you should check if any of the requested tasks is a publish task. This will correctly detect the intention to publish regardless of other tasks on the command line.
if (project.gradle.startParameter.taskNames.any { it.endsWith('publish') || it.endsWith('publishToMavenLocal') }) {
apply from: 'archive.gradle'
}
This is an automated backport of the following:
Please merge this PR after all checks have passed.