Skip to content

Conversation

@feeblefakie
Copy link
Contributor

This is an automated backport of the following:

Please merge this PR after all checks have passed.

@gemini-code-assist
Copy link

Summary of Changes

Hello @feeblefakie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request backports essential JReleaser deployment settings to branch(3), specifically integrating the HashStore and TableStore modules into the Maven staging deployment process. This update is crucial for standardizing the release pipeline and ensuring these components are correctly handled during deployment, maintaining alignment with the main development branch's capabilities.

Highlights

  • JReleaser Configuration: The JReleaser Maven staging deployment configuration in build.gradle has been updated to include the HashStore and TableStore modules.
  • Automated Backport: This pull request is an automated backport of a previous commit, ensuring consistency across branches.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds hash-store and table-store to the JReleaser deployment configuration. The change is straightforward and necessary for publishing these new modules. I have one suggestion to refactor how the list of staging repositories is defined, which will improve future maintainability.

Comment on lines 135 to +140
def stagingRepositories = ['client/build/staging-deploy',
'common/build/staging-deploy',
'hash-store/build/staging-deploy',
'ledger/build/staging-deploy',
'rpc/build/staging-deploy']
'rpc/build/staging-deploy',
'table-store/build/staging-deploy']

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better long-term maintainability, consider defining the list of modules to be deployed separately from their path construction. This approach makes it clearer which modules are included and programmatically ensures the list is always sorted, which can prevent manual sorting errors in the future.

            def stagingRepositories = ['client', 'common', 'hash-store', 'ledger', 'rpc', 'table-store']
                .sort()
                .collect { "$it/build/staging-deploy" }

@jnmt jnmt merged commit e536e1c into 3 Sep 22, 2025
10 checks passed
@jnmt jnmt deleted the 3-pull-274 branch September 22, 2025 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants