Skip to content

Add ability to customize working directory of forked process #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2022
Merged

Add ability to customize working directory of forked process #83

merged 1 commit into from
Jul 3, 2022

Conversation

@GrigorievNick
Copy link
Contributor

No description provided.

@cla-bot
Copy link

cla-bot bot commented Jan 22, 2021

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: mykola.hryhoriev.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@GrigorievNick GrigorievNick force-pushed the add-custom-wroking-dir branch from 8ba26ca to 21e2aac Compare January 22, 2021 08:49
@cla-bot
Copy link

cla-bot bot commented Jan 22, 2021

Hi @GrigorievNick, we require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please access https://www.artima.com/cla/choose-type to sign our Contributor License Agreement. Your effort is highly appreciated. Thank you.

@artimasites
Copy link

@cla-bot[bot] check

@cla-bot cla-bot bot added the cla-signed label Jan 22, 2021
@cla-bot
Copy link

cla-bot bot commented Jan 22, 2021

The cla-bot has been summoned, and re-checked this pull request!

@GrigorievNick
Copy link
Contributor Author

Who can review this?

@bvenners bvenners requested a review from cheeseng April 12, 2021 21:12
@bvenners
Copy link
Contributor

@GrigorievNick Tnx for the contribution. Sorry for the delay in reviewing. I've assigned it to Chee Seng so he'll look at it soon.

@GrigorievNick GrigorievNick force-pushed the add-custom-wroking-dir branch from 1b54d8b to 593d20e Compare April 12, 2021 21:27
cheeseng
cheeseng reviewed Apr 14, 2021
View reviewed changes
pom.xml Outdated
<snapshotRepository>
<id>snapshots</id>
<name>AppsFlyer Artifactory-snapshots</name>
<url>https://artifactory.appsflyer.com/artifactory/maven-snapshots/</url>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GrigorievNick Just curious, do we need any artifact from snapshots?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cheeseng I am sorry I just deploy this to my own artifactory.
and accidentally commit custom pom details.

cheeseng
cheeseng reviewed Apr 14, 2021
View reviewed changes
pom.xml Outdated
<id>sign-artifacts</id>
<phase>verify</phase>
<configuration>
<skip>true</skip>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GrigorievNick Do you mind to enlighten us why you need to set the skip to true?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cheeseng I am sorry I just deploy this to my own artifactory.
and accidentally commit custom pom details.

@GrigorievNick GrigorievNick force-pushed the add-custom-wroking-dir branch from 593d20e to 6b0c06a Compare April 14, 2021 07:34
cheeseng
cheeseng approved these changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@cheeseng cheeseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bvenners @GrigorievNick This PR looks good to me, thanks!

@GrigorievNick
Copy link
Contributor Author

Any news on it, I don't want to keep my custom fork in Company's corporate repo for too long.

@cheeseng
Copy link
Contributor

cheeseng commented Jul 1, 2022

@GrigorievNick I am really sorry for getting back here so late, hopefully this round we'll get this in!

@bvenners bvenners merged commit d61e298 into scalatest:master Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheeseng cheeseng cheeseng approved these changes

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GrigorievNick @artimasites @bvenners @cheeseng