-
Notifications
You must be signed in to change notification settings - Fork 67
Support checkpoint_path for endpoint creation #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -131,17 +131,27 @@ class CreateLLMEndpointRequest(BaseModel): | |
| # LLM specific fields | ||
| model_name: str | ||
| source: LLMSource = LLMSource.HUGGING_FACE | ||
| inference_framework: LLMInferenceFramework = LLMInferenceFramework.DEEPSPEED | ||
| inference_framework: LLMInferenceFramework = LLMInferenceFramework.TEXT_GENERATION_INFERENCE | ||
| inference_framework_image_tag: str | ||
| num_shards: int | ||
| num_shards: int = 1 | ||
| """ | ||
| Number of shards to distribute the model onto GPUs. | ||
| Number of shards to distribute the model onto GPUs. Only affects behavior for text-generation-inference models | ||
| """ | ||
|
|
||
| quantize: Optional[Quantization] = None | ||
| """ | ||
| Quantization for the LLM. Only affects behavior for text-generation-inference models | ||
| """ | ||
|
|
||
| checkpoint_path: Optional[str] = None | ||
| """ | ||
| Path to the checkpoint to load the model from. Only affects behavior for text-generation-inference models | ||
| """ | ||
|
|
||
| # General endpoint fields | ||
| metadata: Dict[str, Any] # TODO: JSON type | ||
| post_inference_hooks: Optional[List[str]] | ||
| endpoint_type: ModelEndpointType = ModelEndpointType.SYNC | ||
| endpoint_type: ModelEndpointType = ModelEndpointType.STREAMING | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does this line up with the default on the server?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no, but this lines up with the default endpoint type for TGI |
||
| cpus: CpuSpecificationType | ||
| gpus: int | ||
| memory: StorageSpecificationType | ||
|
|
@@ -156,7 +166,10 @@ class CreateLLMEndpointRequest(BaseModel): | |
| high_priority: Optional[bool] | ||
| default_callback_url: Optional[HttpUrl] | ||
| default_callback_auth: Optional[CallbackAuth] | ||
| public_inference: Optional[bool] = True # LLM endpoints are public by default. | ||
| public_inference: Optional[bool] = True | ||
| """ | ||
| Whether the endpoint can be used for inference for all users. LLM endpoints are public by default. | ||
| """ | ||
|
|
||
|
|
||
| class CreateLLMEndpointResponse(BaseModel): | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a breaking change? Seems like we're changing default functionality. Might be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think people could run build deepspeed models right now