-
Notifications
You must be signed in to change notification settings - Fork 67
adding download api to launch client, updating example #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
aaa5cd4
adding launch client modifications to handle download api, updating e…
ian-scale-2 27f4908
Merge branch 'main' into download_model_api
ian-scale ad54664
fixing docs error with ModelDownloadResponse
ian-scale-2 db985ac
fixing docs for download function
ian-scale-2 0ec6727
updating llm engine files, removing server changes
ian-scale-2 8c595de
updating response fields
ian-scale-2 3e6a34b
Merge branch 'main' into download_model_api
ian-scale b1a804c
updating to return dict and not list in response
ian-scale-2 20785b7
adding change to docs
ian-scale-2 7420267
updating example
ian-scale-2 a47ac17
adding comment about presigned urls
ian-scale-2 275f034
fixing precommit
ian-scale-2 be076a9
Merge branch 'main' into download_model_api
ian-scale ae086b1
changing hugging face var
ian-scale-2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,6 +21,7 @@ | |
| - get | ||
| - list | ||
| - delete | ||
| - download | ||
|
|
||
| ::: llmengine.File | ||
| selection: | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think this is OK for now, but not sure if this is technically true in all contexts, e.g. self-hosting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This make sense, I'm actually not exactly sure what the behavior would be in a self-hosted context. We can think about this more as it becomes relevant in the future?