Skip to content

Pass labels to job config #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2023
Merged

Pass labels to job config #251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ...gine/model_engine_server/infra/services/docker_image_batch_job_llm_fine_tuning_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,14 @@ async def create_fine_tune(
if not di_batch_job_bundle.public and di_batch_job_bundle.owner != owner:
raise LLMFineTuningMethodNotImplementedException("Fine-tuning method not accessible")

# TODO: Pass user-defined labels
labels = dict(team="egp", product="llm-fine-tune")

batch_job_id = await self.docker_image_batch_job_gateway.create_docker_image_batch_job(
created_by=created_by,
owner=owner,
job_config=dict(
**labels,
gateway_url=os.getenv("GATEWAY_URL"),
user_id=owner,
training_file=training_file,
Expand All @@ -97,8 +101,7 @@ async def create_fine_tune(
gpu_type=di_batch_job_bundle.gpu_type,
storage=di_batch_job_bundle.storage,
),
# TODO: Pass user-defined labels
labels=dict(team="egp", product="llm-fine-tune"),
labels=labels,
annotations=dict(fine_tuned_model=fine_tuned_model),
mount_location=di_batch_job_bundle.mount_location,
)
Expand Down