Skip to content

Selecting task selects agent name and task id #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2025
Merged

Selecting task selects agent name and task id #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f241a18
Selecting task selects agent name and task id
declan-scale Oct 29, 2025
dadadb6
useMemo
declan-scale Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 11 additions & 13 deletions agentex-ui/app/agentex-ui-root.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use client';

import { Suspense, useCallback, useEffect, useState } from 'react';
import { useCallback, useEffect, useState } from 'react';

import { ToastContainer } from 'react-toastify';

Expand Down Expand Up @@ -70,18 +70,16 @@ export function AgentexUIRoot({
sgpAppURL={sgpAppURL ?? ''}
agentexAPIBaseURL={agentexAPIBaseURL}
>
<Suspense fallback={<div>Loading...</div>}>
<div className="fixed inset-0 flex w-full">
<TaskSidebar />
<PrimaryContent
isTracesSidebarOpen={isTracesSidebarOpen}
toggleTracesSidebar={() =>
setIsTracesSidebarOpen(!isTracesSidebarOpen)
}
/>
<TracesSidebar isOpen={isTracesSidebarOpen} />
</div>
</Suspense>
<div className="fixed inset-0 flex w-full">
<TaskSidebar />
<PrimaryContent
isTracesSidebarOpen={isTracesSidebarOpen}
toggleTracesSidebar={() =>
setIsTracesSidebarOpen(!isTracesSidebarOpen)
}
/>
<TracesSidebar isOpen={isTracesSidebarOpen} />
</div>
</AgentexProvider>
<ToastContainer />
</QueryProvider>
Expand Down
8 changes: 7 additions & 1 deletion agentex-ui/components/agentex/task-sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,19 @@ function TaskButton({ task }: TaskButtonProps) {
const { taskID, updateParams } = useSafeSearchParams();
const taskName = createTaskName(task);

const firstAgentName = useMemo(
() => task.agents?.[0]?.name ?? null,
[task.agents]
);

const handleTaskSelect = useCallback(
(taskID: TaskListResponse.TaskListResponseItem['id']) => {
updateParams({
[SearchParamKey.TASK_ID]: taskID,
[SearchParamKey.AGENT_NAME]: firstAgentName,
});
},
[updateParams]
[updateParams, firstAgentName]
);

const createdAtString = useMemo(
Expand Down
6 changes: 0 additions & 6 deletions agentex-ui/components/providers/task-provider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,9 @@ import { useTaskSubscription } from '@/hooks/use-task-subscription';
export function TaskProvider({
taskId,
children,
fallback,
}: {
taskId: string;
children: ReactNode;
fallback?: ReactNode;
}) {
const { agentexClient } = useAgentexClient();
const { agentName } = useSafeSearchParams();
Expand All @@ -28,9 +26,5 @@ export function TaskProvider({
enabled: !!taskId && agent?.acp_type === 'agentic',
});

if (!taskId && fallback) {
return <>{fallback}</>;
}

return <>{children}</>;
}