Skip to content

Add memberAlias instead of memberId #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 20, 2019
Merged

Add memberAlias instead of memberId #257

merged 2 commits into from
Sep 20, 2019

Conversation

@artem-v
Copy link
Contributor

@artem-v artem-v commented Sep 20, 2019 •
edited
Loading

Fixes #252

ClusterJoinExamples with member aliases:

Alice (127.0.1.1:44173) cluster: 
Alice/45506989587c4b2a@127.0.1.1:44173
Bob/ebd6435d9924c78@127.0.1.1:42575
Dan/7b518974130240c2@127.0.1.1:3000
Carol/1b739ea3c8eb420c@127.0.1.1:35263

Bob (127.0.1.1:42575) cluster: 
Bob/ebd6435d9924c78@127.0.1.1:42575
Alice/45506989587c4b2a@127.0.1.1:44173
Dan/7b518974130240c2@127.0.1.1:3000
Carol/1b739ea3c8eb420c@127.0.1.1:35263

Carol (127.0.1.1:35263) cluster: 
Alice/45506989587c4b2a@127.0.1.1:44173
Bob/ebd6435d9924c78@127.0.1.1:42575
Dan/7b518974130240c2@127.0.1.1:3000
Carol/1b739ea3c8eb420c@127.0.1.1:35263

Dan (127.0.1.1:3000) cluster: 
Alice/45506989587c4b2a@127.0.1.1:44173
Bob/ebd6435d9924c78@127.0.1.1:42575
Dan/7b518974130240c2@127.0.1.1:3000
Carol/1b739ea3c8eb420c@127.0.1.1:35263

Eve (127.0.1.1:36591) cluster: 
Eve/38d2684f21f74feb@127.0.1.1:36591

@artem-v
Added AbstractMonitorMBean
2e3d8f1
@artem-v
Enhanced cluster.jmx-monitor: exposed few more properties; changed co…
2df9fde 
…nstructor for Member; removed `memberId` instead started to use `memberAlias`
@artem-v artem-v changed the title More properties on jmx cluster bean Add memberAlias instead of memberId Sep 20, 2019
segabriel
segabriel approved these changes Sep 20, 2019
View reviewed changes
Copy link
Member

@segabriel segabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it 👍

@artem-v artem-v merged commit 5a0f397 into develop Sep 20, 2019
@artem-v artem-v deleted the more-properties-on-jmx-cluster-bean branch September 20, 2019 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@segabriel segabriel segabriel approved these changes

@dmytro-lazebnyi dmytro-lazebnyi dmytro-lazebnyi approved these changes

@ronenhamias ronenhamias Awaiting requested review from ronenhamias

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add cluster member name/alias (in addition to id)

4 participants

@artem-v @segabriel @dmytro-lazebnyi