Skip to content

Conversation

@artem-v
Copy link
Contributor

@artem-v artem-v commented Sep 22, 2019

Motivation:
Shorten jmx support in the code. Don't scatter jmx functionality over many classes, keep MBean in one class.

After update:

jmx-term gives following:

$>info
#mbean = io.scalecube.cluster:name=Cluster@3f87e86f7a9c483e
#class name = io.scalecube.cluster.monitor.JmxClusterMonitorMBean
# attributes
  %0   - AliveMembers (java.lang.String, r)
  %1   - ClusterConfig (java.lang.String, r)
  %2   - ClusterSize (int, r)
  %3   - Member (java.lang.String, r)
  %4   - MemberIncarnation (int, r)
  %5   - Metadata (java.lang.String, r)
  %6   - RemovedMembers (java.lang.String, r)
  %7   - SeedMembers (java.lang.String, r)
  %8   - SuspectedMembers (java.lang.String, r)

All monitoring attributes are gathered in a single MBean class.

@artem-v artem-v changed the title Refactoring/remove jmx method duplicates Refactor Jmx support, add attributes, shorten implementation Sep 22, 2019
@artem-v artem-v merged commit cb545bc into develop Sep 22, 2019
@artem-v artem-v deleted the refactoring/remove-jmx-method-duplicates branch September 22, 2019 17:14
io-scalecube-ci added a commit that referenced this pull request Sep 23, 2019
…duplicates

Refactor Jmx support, add attributes, shorten implementation [skip ci] prepare release v2.4.5
io-scalecube-ci added a commit that referenced this pull request Sep 23, 2019
…duplicates

Refactor Jmx support, add attributes, shorten implementation [skip ci] prepare for next development iteration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants