-
Notifications
You must be signed in to change notification settings - Fork 91
Upgrade to Jackson 2.10.0 #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
linux-china
commented
Mar 10, 2020
- "enableDefaultTyping" is deleted from ObjetMapper and replaced by "activateDefaultTyping"
- Change DefaultObjectMapper to public, and allow developers to customize ObjectMapper's configuration. For example support CloudEventImpl en/decoding from CloudEvents Java SDK
…ause of API changed
… example CloudEventImpl class from CloudEvents Java SDK
|
@linux-china when you say
Do u mean this -- https://github.com/cloudevents/spec? |
artem-v
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't make public on DefaultObjectMapper\s. They are supposed to be package private, if u need custom ObjectMapper to put into io.scalecube.cluster.codec.jackson.JacksonMessageCodec/io.scalecube.cluster.codec.jackson.smile.JacksonSmileMessageCodec then use corresp. constructor.
|
|
Check this one: https://github.com/FasterXML/jackson-modules-java8#jackson-2x
Since u're going to set 2.10 so go and try this option |
artem-v
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Request changes: #308 (comment)
Great idea 👍 Just register modules on services/com.fasterxml.jackson.databind.Module file, and ObjectMapper customized done. |
Fix codacy. It complains about unused imports. |