Skip to content

Cleanup of Properties usage #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2025
Merged

Cleanup of Properties usage #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions metrics/src/main/java/io/scalecube/metrics/CountersRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ public Context countersValuesBufferLength(int countersValuesBufferLength) {

public Context countersValuesBufferLength(String countersValuesBufferLength) {
if (countersValuesBufferLength != null) {
this.countersValuesBufferLength = Integer.parseInt(countersValuesBufferLength);
return countersValuesBufferLength(Integer.parseInt(countersValuesBufferLength));
}
return this;
}
Expand Down Expand Up @@ -236,7 +236,7 @@ public Context dirDeleteOnShutdown(boolean dirDeleteOnShutdown) {

public Context dirDeleteOnShutdown(String dirDeleteOnShutdown) {
if (dirDeleteOnShutdown != null) {
this.dirDeleteOnShutdown = Boolean.parseBoolean(dirDeleteOnShutdown);
return dirDeleteOnShutdown(Boolean.parseBoolean(dirDeleteOnShutdown));
}
return this;
}
Expand Down
8 changes: 4 additions & 4 deletions metrics/src/main/java/io/scalecube/metrics/MetricsRecorder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ public Context dirDeleteOnShutdown(boolean dirDeleteOnShutdown) {

public Context dirDeleteOnShutdown(String dirDeleteOnShutdown) {
if (dirDeleteOnShutdown != null) {
this.dirDeleteOnShutdown = Boolean.parseBoolean(dirDeleteOnShutdown);
return dirDeleteOnShutdown(Boolean.parseBoolean(dirDeleteOnShutdown));
}
return this;
}
Expand Down Expand Up @@ -396,7 +396,7 @@ public Context metricsBufferLength(int metricsBufferLength) {

public Context metricsBufferLength(String metricsBufferLength) {
if (metricsBufferLength != null) {
this.metricsBufferLength = Integer.parseInt(metricsBufferLength);
return metricsBufferLength(Integer.parseInt(metricsBufferLength));
}
return this;
}
Expand Down Expand Up @@ -427,8 +427,8 @@ public Context idleStrategy(IdleStrategy idleStrategy) {
public Context idleStrategy(String idleStrategy) {
if (idleStrategy != null) {
try {
this.idleStrategy =
(IdleStrategy) Class.forName(idleStrategy).getConstructor().newInstance();
return idleStrategy(
(IdleStrategy) Class.forName(idleStrategy).getConstructor().newInstance());
} catch (Exception ex) {
LangUtil.rethrowUnchecked(ex);
}
Expand Down
16 changes: 8 additions & 8 deletions metrics/src/main/java/io/scalecube/metrics/MetricsTransmitter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ public Context warnIfMetricsNotExists(boolean warnIfMetricsNotExists) {

public Context warnIfMetricsNotExists(String warnIfMetricsNotExists) {
if (warnIfMetricsNotExists != null) {
this.warnIfMetricsNotExists = Boolean.parseBoolean(warnIfMetricsNotExists);
return warnIfMetricsNotExists(Boolean.parseBoolean(warnIfMetricsNotExists));
}
return this;
}
Expand All @@ -280,8 +280,8 @@ public Context retryInterval(Duration retryInterval) {

public Context retryInterval(String retryInterval) {
if (retryInterval != null) {
this.retryInterval =
Duration.ofNanos(SystemUtil.parseDuration("retryInterval", retryInterval));
return retryInterval(
Duration.ofNanos(SystemUtil.parseDuration("retryInterval", retryInterval)));
}
return this;
}
Expand All @@ -297,8 +297,8 @@ public Context heartbeatTimeout(Duration heartbeatTimeout) {

public Context heartbeatTimeout(String heartbeatTimeout) {
if (heartbeatTimeout != null) {
this.heartbeatTimeout =
Duration.ofNanos(SystemUtil.parseDuration("heartbeatTimeout", heartbeatTimeout));
return heartbeatTimeout(
Duration.ofNanos(SystemUtil.parseDuration("heartbeatTimeout", heartbeatTimeout)));
}
return this;
}
Expand Down Expand Up @@ -329,8 +329,8 @@ public Context idleStrategy(IdleStrategy idleStrategy) {
public Context idleStrategy(String idleStrategy) {
if (idleStrategy != null) {
try {
this.idleStrategy =
(IdleStrategy) Class.forName(idleStrategy).getConstructor().newInstance();
return idleStrategy(
(IdleStrategy) Class.forName(idleStrategy).getConstructor().newInstance());
} catch (Exception ex) {
LangUtil.rethrowUnchecked(ex);
}
Expand All @@ -353,7 +353,7 @@ public Context broadcastBufferLength(int broadcastBufferLength) {

public Context broadcastBufferLength(String broadcastBufferLength) {
if (broadcastBufferLength != null) {
this.broadcastBufferLength = Integer.parseInt(broadcastBufferLength);
return broadcastBufferLength(Integer.parseInt(broadcastBufferLength));
}
return this;
}
Expand Down