add scope validation in validate_token method #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrishikesh-p
approved these changes
Jul 30, 2025
jranaskit
requested changes
Jul 31, 2025
scalekit/client.py
Outdated
| raise exp | ||
|
|
||
| def validate_access_token_and_get_claims(self, token: str, options: Optional[Dict] = None, audience = None) -> Dict[str, Any]: | ||
| def validate_access_token_and_get_claims(self, token: str, options: Optional[TokenValidationOptions] = None) -> Dict[str, Any]: |
There was a problem hiding this comment.
We have removed audience parameter from the params. Would it be ok as it would break for any customers already using this method.
jranaskit
requested changes
Jul 31, 2025
scalekit/client.py
Outdated
| if options.issuer: | ||
| jwt_options["issuer"] = options.issuer | ||
| if options.audience: | ||
| audience = options.audience[0] if len(options.audience) == 1 else options.audience |
There was a problem hiding this comment.
This logic needs to be refined.
We are converting audience to str if len(options.audience) == 1 or else we pas the list itself. Why is the conversion required of len = 1 as well?
Secondly, if user has provided audience separately in params, then we should take that as well in consideration and put it in options block itself and send only options block to jwt.decode()
jranaskit
requested changes
Jul 31, 2025
jranaskit
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.