Rename resource parameter to target for resource scoped grant.
#9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While resource is still supported for backwards compatibility, it conflicts with a standard parameter in the newer OAuth specs.
There was a problem hiding this comment.
Pull Request Overview
This PR renames the resource parameter to target in the resource scoped grant implementation to align with newer OAuth specifications while maintaining backwards compatibility. This is a breaking change planned for v2 release.
- Renames parameter from
resourcetotargetacross the ResourceScopedAccessGrantParameters class - Updates the token client implementation to use the new parameter name
- Modifies test validation to check for the new
targetparameter
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ResourceScopedAccessGrantParameters.java | Updates constructor parameters, field names, getter method, and documentation from resource to target |
| ResourceScopedAccessGrantTokenClient.java | Changes HTTP parameter name from resource to target when building POST request |
| ValidResourceScopedAccessRequestCallback.java | Updates test validation to check for target parameter instead of resource |
src/test/java/com/scalepoint/oauth_token_client/ValidResourceScopedAccessRequestCallback.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While resource is still supported for backwards compatibility, it conflicts with a standard parameter in the newer OAuth specs.
This is a breaking change and will be released with v2.