rdb: add instance connect #1170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remyleone
commented
Jul 3, 2020
This was
linked to
issues
Jul 3, 2020
jerome-quere
suggested changes
Jul 3, 2020
|
|
||
| const ( | ||
| Unknown = engineFamily("Unknown") | ||
| PostgreSQL = engineFamily("PostgreSQL") |
Contributor
There was a problem hiding this comment.
Should it exist in rdb API ?
Member
Author
There was a problem hiding this comment.
@nlm What do you think about having const in your API about the kind of engine a given instance is running? Without the version, ie PostgreSQL instead of PostgreSQL-12.
| } | ||
| } | ||
|
|
||
| func detectEngineFamily(instance *rdb.Instance) (engineFamily, error) { |
Contributor
There was a problem hiding this comment.
I feel like this feature should be in the RDB api
jerome-quere
reviewed
Jul 3, 2020
jerome-quere
suggested changes
Jul 13, 2020
cmd/scw/testdata/test-all-usage-rdb-instance-connect-usage.golden
Outdated
Show resolved
Hide resolved
cmd/scw/testdata/test-all-usage-rdb-instance-connect-usage.golden
Outdated
Show resolved
Hide resolved
jerome-quere
approved these changes
Jul 13, 2020
remyleone
added
the
rdb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Release note for CHANGELOG: