rdb: add human marshaller for instance #1182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerome-quere
reviewed
Jul 7, 2020
remyleone
force-pushed
the
human_marshallers_db
branch
from
88c65db to
a9baaa9
Compare
jerome-quere
force-pushed
the
human_marshallers_db
branch
from
4f608f1 to
23cb050
Compare
jerome-quere
approved these changes
Jul 7, 2020
This was
linked to
issues
Jul 7, 2020
| } | ||
|
|
||
| sort.Slice(result, func(i, j int) bool { | ||
| n := 0 |
Contributor
There was a problem hiding this comment.
When do you increase n?
| return result[i][n] < result[j][n] | ||
| } | ||
| } | ||
| panic("this can never happen") |
Contributor
There was a problem hiding this comment.
Agree with you since this is an infinite loop :-)
remyleone
added
the
rdb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Release note for CHANGELOG: