Skip to content

fix(rdb): fix human marshaler for rdb BackupSchedule #1196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2020
Merged

fix(rdb): fix human marshaler for rdb BackupSchedule #1196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44add99
fix(rdb): fix human marshaler for rdb BackupSchedule
jerome-quere Jul 8, 2020
93661e4
Merge branch 'v2' into fix-rdb-backup
remyleone Jul 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/namespaces/rdb/v1/custom_instance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ func backupScheduleMarshalerFunc(i interface{}, opt *human.MarshalOpt) (string,
backupSchedule := tmp{
LocalBackupSchedule: LocalBackupSchedule(i.(rdb.BackupSchedule)),
Frequency: &scw.Duration{
Seconds: int64(i.(rdb.BackupSchedule).Frequency) * 24 * 3600,
Seconds: int64(i.(rdb.BackupSchedule).Frequency) * 3600,
},
Retention: &scw.Duration{
Seconds: int64(i.(rdb.BackupSchedule).Retention) * 24 * 3600,
Expand Down
2 changes: 1 addition & 1 deletion internal/namespaces/rdb/v1/testdata/test-clone-instance-simple.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Size 25 GB

Backup Schedule:
Disabled false
Frequency 24 days
Frequency 1 days
Retention 7 days

Settings:
Expand Down
2 changes: 1 addition & 1 deletion internal/namespaces/rdb/v1/testdata/test-create-instance-simple.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Size 5.0 GB

Backup Schedule:
Disabled false
Frequency 24 days
Frequency 1 days
Retention 7 days

Settings:
Expand Down
2 changes: 1 addition & 1 deletion internal/namespaces/rdb/v1/testdata/test-get-instance-simple.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Size 5.0 GB

Backup Schedule:
Disabled false
Frequency 24 days
Frequency 1 days
Retention 7 days

Settings:
Expand Down
2 changes: 1 addition & 1 deletion internal/namespaces/rdb/v1/testdata/test-upgrade-instance-simple.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Size 25 GB

Backup Schedule:
Disabled false
Frequency 24 days
Frequency 1 days
Retention 7 days

Settings:
Expand Down