Skip to content

chore(rdb): remove get-metric command #1239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2020
Merged

chore(rdb): remove get-metric command #1239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cmd/scw/testdata/test-all-usage-rdb-instance-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ AVAILABLE COMMANDS:
delete Delete an instance
get Get an instance
get-certificate Get the TLS certificate of an instance
get-metrics Get instance metrics
list List instances
update Update an instance
upgrade Upgrade an instance to an higher instance type
Expand Down
47 changes: 0 additions & 47 deletions internal/namespaces/rdb/v1/rdb_cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ func GetGeneratedCommands() *core.Commands {
rdbLogPrepare(),
rdbLogList(),
rdbLogGet(),
rdbInstanceGetMetrics(),
rdbSettingsAdd(),
rdbSettingsDelete(),
rdbACLList(),
Expand Down Expand Up @@ -940,52 +939,6 @@ func rdbLogGet() *core.Command {
}
}

func rdbInstanceGetMetrics() *core.Command {
return &core.Command{
Short: `Get instance metrics`,
Long: `Get database instance metrics.`,
Namespace: "rdb",
Resource: "instance",
Verb: "get-metrics",
ArgsType: reflect.TypeOf(rdb.GetInstanceMetricsRequest{}),
ArgSpecs: core.ArgSpecs{
{
Name: "instance-id",
Short: `UUID of the instance`,
Required: true,
Positional: true,
},
{
Name: "start-date",
Short: `Start date to gather metrics from`,
Required: false,
Positional: false,
},
{
Name: "end-date",
Short: `End date to gather metrics from`,
Required: false,
Positional: false,
},
{
Name: "metric-name",
Short: `Name of the metric to gather`,
Required: false,
Positional: false,
},
core.RegionArgSpec(scw.RegionFrPar, scw.RegionNlAms),
},
Run: func(ctx context.Context, args interface{}) (i interface{}, e error) {
request := args.(*rdb.GetInstanceMetricsRequest)

client := core.ExtractClient(ctx)
api := rdb.NewAPI(client)
return api.GetInstanceMetrics(request)

},
}
}

func rdbSettingsAdd() *core.Command {
return &core.Command{
Short: `Add an instance setting`,
Expand Down