Skip to content

Conversation

@moul
Copy link
Contributor

@moul moul commented Aug 26, 2015

No description provided.

@QuentinPerez
Copy link
Contributor

LGTM 👍

@moul moul changed the title Support of 'scw images --filter' (#134) Support of 'scw {images,ps} --filter' (#134) Aug 26, 2015
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add an extra check to ensure len(parts) == 2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch dude

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed with 672c193

@moul moul force-pushed the fix-134-filters branch from 655ffb6 to 672c193 Compare August 26, 2015 14:02
@aimxhaisse
Copy link
Contributor

LGTM

moul added a commit that referenced this pull request Aug 26, 2015
Support of 'scw {images,ps} --filter' (#134)
@moul moul merged commit eab1d54 into scaleway:master Aug 26, 2015
@moul moul removed the in progress label Aug 26, 2015
@moul moul deleted the fix-134-filters branch August 26, 2015 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants